Hi Ivan,
code changes looks good to me, although i am not the official reviewer.
Thanks,
Vyom
On Thursday 28 June 2018 04:45 AM, Ivan Gerasimov wrote:
Hello!
When closing a socket via NET_SocketClose(int fd), a close(fd) is called.
The later is wrapped in a retry-loop, which is wrong becaus
Thanks David!
On 6/27/18 4:23 PM, David Lloyd wrote:
According to http://man7.org/linux/man-pages/man2/close.2.html it is
currently platform-dependent whether close() must or must not (seems
to be no middle ground) be retried. Might have to do some #ifdef
guarding?
Right.
Here I'm patchi
Hello!
When closing a socket via NET_SocketClose(int fd), a close(fd) is called.
The later is wrapped in a retry-loop, which is wrong because close() is
not restartable.
The `man 2 close` states:
"""
... close() should not be retried after an EINTR since this may cause a
reused descriptor fro
+1
On 6/27/2018 1:15 PM, Alan Bateman wrote:
On 27/06/2018 18:09, Daniel Fuchs wrote:
Hi,
Please find below a trivial fix for:
https://bugs.openjdk.java.net/browse/JDK-8205397
8205397: InetAddress has wrong declaration for readObjectNoData
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev-
On 27/06/2018 18:09, Daniel Fuchs wrote:
Hi,
Please find below a trivial fix for:
https://bugs.openjdk.java.net/browse/JDK-8205397
8205397: InetAddress has wrong declaration for readObjectNoData
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev-8205397.00/
Looks good.
-Alan
Hi,
Please find below a trivial fix for:
https://bugs.openjdk.java.net/browse/JDK-8205397
8205397: InetAddress has wrong declaration for readObjectNoData
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev-8205397.00/
best regards,
-- daniel
