Hi Vyom!
On 4/23/18 11:29 PM, vyom tewari wrote:
Hi Ivan,
code looks good to me, thanks for doing this cleanup. One minor
comment, in PortConfig.java you can make defaultUpper& defaultLower as
final.
Yes, of course, they should be final! I'll add it before pushing.
I see that Microsoft
Hi Alan,
Thanks for review comments, please find my answers inline.
Vyom
On Monday 23 April 2018 06:04 PM, Alan Bateman wrote:
On 23/04/2018 13:05, vyom tewari wrote:
Hi,
Please find the latest
webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.1/index.html).
I incorporated most
Hi Vyom,
> I think, it is intentional to handle case where return "hostname" is to large
> to
> fit in array. if you see the man page(http://man7.org/linux/man-
> pages/man2/gethostname.2.html) it says that it is unspecified whether
> returned buffer includes a terminating null byte.
>
> curre
On Tuesday 24 April 2018 03:08 PM, Langer, Christoph wrote:
Hi,
please help reviewing a small change that I stumbled over when looking
into the getLocalHostName implementation. I found that the length of
the hostname buffer is not correctly passed to sub functions. The
buffer size is speci
Hi,
please help reviewing a small change that I stumbled over when looking into the
getLocalHostName implementation. I found that the length of the hostname buffer
is not correctly passed to sub functions. The buffer size is specified as
"NI_MAXHOST + 1", so this size should be handed down to g
Hi Ivan,
looks good. I agree that the fields that Vyom mentioned should be final.
Best regards
Christoph
From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of vyom tewari
Sent: Dienstag, 24. April 2018 08:29
To: net-dev@openjdk.java.net
Subject: Re: RFR 8202154 : Remove unused cod
