Re: RFR 8201510 : Merge TwoStacksPlainSocketImpl into DualStackPlainSocketImpl [win]

> On 19 Apr 2018, at 10:12, Ivan Gerasimov wrote: > > Thanks again Chris! > No, thank you. This is a nice simplification of the code. Next step, maybe remove DualStackPlainSocketImpl and merge it into PlainSocketImpl? -Chris.

Re: RFR 8201510 : Merge TwoStacksPlainSocketImpl into DualStackPlainSocketImpl [win]

Thanks again Chris! On 4/19/18 1:50 AM, Chris Hegarty wrote: On 19 Apr 2018, at 09:44, Ivan Gerasimov > wrote: ... WEBREV:http://cr.openjdk.java.net/~igerasim/8201510/01/webrev/ Thanks Ivan. Thi

Re: RFR 8201510 : Merge TwoStacksPlainSocketImpl into DualStackPlainSocketImpl [win]

> On 19 Apr 2018, at 09:44, Ivan Gerasimov wrote: > > ... > > WEBREV: http://cr.openjdk.java.net/~igerasim/8201510/01/webrev/ > Thanks Ivan. This looks good, and thanks for updating the existing tests to cover the property values ( yo

Re: RFR 8201510 : Merge TwoStacksPlainSocketImpl into DualStackPlainSocketImpl [win]

Thanks you Chris for reviewing this! On 4/18/18 9:06 AM, Chris Hegarty wrote: Ivan, On 16/04/18 17:29, Ivan Gerasimov wrote: ... WEBREV: http://cr.openjdk.java.net/~igerasim/8201510/00/webrev/ I think this is mostly good. Just one comment. I'm not sure that this is correct. --- OLD ---