On 2018/4/18 14:07, vyom tewari wrote:
Hi Felix,
latest code looks good to me, personally i prefer to throw exception
instead returning null, but i can see that old code was also returning
null.
Yes, that was initial version, but it will make the test failing on host
without IPv6 configure
Hi Felix,
latest code looks good to me, personally i prefer to throw exception
instead returning null, but i can see that old code was also returning
null. Hopping the code which invokes getFirstLocalIPv4Address,
getFirstLocalIPv6Addres already taken care of null.
Thanks,
Vyom
On Wednesda
> On 18 Apr 2018, at 06:35, Felix Yang wrote:
>
> Hi Chris and Wyom,
>
> fixed as commented. Updated webrev:
>
> http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.01/
Looks good,
-Chris.
> Thanks,
> Felix
> On 2018/4/17 16:25, Chris Hegarty wrote:
>>> On 17 Apr 2018, at 04:34, Fe
Hi Chris and Wyom,
fixed as commented. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.01/
Thanks,
Felix
On 2018/4/17 16:25, Chris Hegarty wrote:
On 17 Apr 2018, at 04:34, Felix Yang wrote:
...
http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.00/
Thanks f
On Tue, Apr 17, 2018 at 6:28 PM, Chris Hegarty
wrote:
> On 17 Apr 2018, at 17:52, Viktor Klang wrote:
> > ...
> > There is technical and non-technical effort required. It is non-trivial.
> > That said, we’re making every effort possible to move this forward.
> >
> > Hi Chris,
> >
> > how can we
On 17 Apr 2018, at 17:52, Viktor Klang wrote:
> ...
> There is technical and non-technical effort required. It is non-trivial.
> That said, we’re making every effort possible to move this forward.
>
> Hi Chris,
>
> how can we help?
Thank you for asking, but I think we have it under control. I h
On Tue, Apr 17, 2018 at 9:55 AM, Chris Hegarty
wrote:
> Simone,
>
> > On 16 Apr 2018, at 18:47, Simone Bordet wrote:
> >
> >> ...
> >
> > Out of curiosity, is this code implementing the ReactiveStreams TCK
> > (in its Flow declination) ?
>
> The code should be compliant with the RS TCK.
>
> > I
Simone,
> On 16 Apr 2018, at 18:47, Simone Bordet wrote:
>
>> ...
>
> Out of curiosity, is this code implementing the ReactiveStreams TCK
> (in its Flow declination) ?
The code should be compliant with the RS TCK.
> I ask because I have recently implemented it for Jetty's Reactive
> HttpClien
> On 17 Apr 2018, at 04:34, Felix Yang wrote:
> ...
> http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.00/
Thanks for doing this Felix. Mainly looks good. Just a few comments.
The old test runs on systems without IPv4 or IPv6 configured. So
I think the Optional `get` should be replaced wi
