Re: RFR 8194260, Point-to-point interface should be excluded from java/net/ipv6tests/*

Hi Felix, Looks good to me, minor bit, please fix the tag order in all the tests, @summary should come immediately after @bug. In Tests.java there are unused imports(import java.net.*, java.io.*) can you please change it to use explicit classes. Thanks, Vyom On Tuesday 17 April 2018 09:04 A

RFR 8194260, Point-to-point interface should be excluded from java/net/ipv6tests/*

Hi all,    please review the following patch to apply NetworkConfiguration library to exclude point-to-point interfaces. Bug:     https://bugs.openjdk.java.net/browse/JDK-8194260 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8194260/webrev.00/ Thanks, Felix

Re: RFR [11] 8197564: HTTP Client implementation - JEP 321

Chris, On Mon, Apr 16, 2018 at 7:09 PM, Chris Hegarty wrote: > Hi, > > Here are refreshed links to the latest code in the sandbox: > > http://cr.openjdk.java.net/~chegar/httpclient/03/javadoc/api/java.net.http/module-summary.html > http://cr.openjdk.java.net/~chegar/httpclient/03/webrev/ > > Incl

Re: RFR [11] 8197564: HTTP Client implementation - JEP 321

Hi, Here are refreshed links to the latest code in the sandbox: http://cr.openjdk.java.net/~chegar/httpclient/03/javadoc/api/java.net.http/module-summary.html http://cr.openjdk.java.net/~chegar/httpclient/03/webrev/ Includes: a) Changes to address the two issues raised by Simone during the

RFR 8201510 : Merge TwoStacksPlainSocketImpl into DualStackPlainSocketImpl [win]

Hello! After integrating the fix for JDK-8198358 there are only a few differences left in these two implementations, so it is relatively easy to merge them together. Some cleanup was done along the way: - unused argument in socket0() was removed, - tests of the IP family were moved from nativ

Re: RFR(XS): 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only

> On 16 Apr 2018, at 10:29, Langer, Christoph wrote: > > Hi Srividya, > > thanks for doing this work. > > Change looks good from my side, except for a small indentation flaw in lines > 91 and 94 and the copyright year that needs to be adjusted. But I can fix > this when I push it. +1 >

RE: RFR:8194298 Add support for per Socket configuration of TCP keepalive

Hi Vyom, I had a quick glance through your changes. Apart from the suggestions you've already got (use snprintf instead of string concatenation, method ordering...), I think "src/jdk.net/macosx/classes/jdk/net/UnixSocketOptions.java" and " src/jdk.net/macosx/native/libextnet/UnixSocketOptions.

Re: RFR(XS): 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only

looks good to me, As Christoph already mentioned just update the copyright date. Vyom On Monday 16 April 2018 02:14 PM, Srividya Shamaiah wrote: Hi Chris, Please review the attached patch in http://cr.openjdk.java.net/~mhorie/8201369/webrev/

RE: RFR(XS): 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only

Hi Srividya, thanks for doing this work. Change looks good from my side, except for a small indentation flaw in lines 91 and 94 and the copyright year that needs to be adjusted. But I can fix this when I push it. Let's wait for another review (Chris) before we can push it. I'll also do some t

RE: JDK-8200719: Cannot connect to IPv6 host when exists any active network interface without IPv6 address

Hi, thanks, I've pushed it then: http://hg.openjdk.java.net/jdk/jdk/rev/bc1c7e41e285 Best regards Christoph > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Freitag, 13. April 2018 16:07 > To: Langer, Christoph ; Joel Peláez Jorge > ; net-dev@openjdk.j

RFR(XS): 8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only

Hi Chris, Please review the attached patch in http://cr.openjdk.java.net/~mhorie/8201369/webrev/ Can you also backport this to JDK 8, we have customers waiting for this fix at JDK 8 level. Thanks, Srividya S From: Srividya Shamaiah/India/IBM To: "Langer, Christoph" Cc: Chris Hegart