Re: RFR [11] 8197564: HTTP Client implementation - JEP 321

2018-03-28 Thread James Roper
On 28 March 2018 at 18:50, Wenbo Zhu wrote: > >>> Any useful RS support will have to involve some application-level >>> protocols. >>> >> >> I completely disagree with this statement. As someone who has been >> involved in/led the implementation of multiple WebSocket clients and >> servers (inclu

Re: RFR [11] 8200304: TwoStacksPlainDatagramSocketImpl and socket cleaner

2018-03-28 Thread Chris Hegarty
> On 28 Mar 2018, at 19:47, Roger Riggs wrote: > > Hi Chris, > > TwoStacksPlainDatagramSocketImpl.java:136 could be explicit about the native > bind0 > changing the state. Ok. > And I agree with Alan that the calls to updateCleaner (:144) should occur > whether or not > the native bind0 thr

Re: RFR [11] 8200304: TwoStacksPlainDatagramSocketImpl and socket cleaner

2018-03-28 Thread Roger Riggs
Hi Chris, TwoStacksPlainDatagramSocketImpl.java:136 could be explicit about the native bind0 changing the state. And I agree with Alan that the calls to updateCleaner (:144) should occur whether or not the native bind0 throws an exception. Thanks, Roger On 3/28/2018 1:22 PM, Alan Bateman w

Re: RFR [11] 8200304: TwoStacksPlainDatagramSocketImpl and socket cleaner

2018-03-28 Thread Alan Bateman
On 28/03/2018 10:08, Chris Hegarty wrote: 8195059 [1] updated the socket implementation to use a cleaner, rather than the previous finalizer implementation. Unfortunately the TwoStacksPlainDatagramSocketImpl on Windows, that uses two native file descriptors, may close one or other when binding, o

RFR [11] 8200304: TwoStacksPlainDatagramSocketImpl and socket cleaner

2018-03-28 Thread Chris Hegarty
8195059 [1] updated the socket implementation to use a cleaner, rather than the previous finalizer implementation. Unfortunately the TwoStacksPlainDatagramSocketImpl on Windows, that uses two native file descriptors, may close one or other when binding, or it may in fact close both sockets and crea