Looks good Chris!
-- daniel
On 16/03/2018 12:54, Chris Hegarty wrote:
On 14/03/18 15:48, Alan Bateman wrote:
On 14/03/2018 15:11, Chris Hegarty wrote:
...
I'm happy to include it in JDK-8199611 as that it doing several
cleanups in this area.
With JDK-8199611 pushed, including SelectionKey
On 14/03/18 15:48, Alan Bateman wrote:
On 14/03/2018 15:11, Chris Hegarty wrote:
...
I'm happy to include it in JDK-8199611 as that it doing several cleanups
in this area.
With JDK-8199611 pushed, including SelectionKey::toString, the
changes here reduce to simply:
--- a/src/jdk.httpserver/
On 16/03/2018 09:00, Hamlin Li wrote:
:
Just to confirm, have you run the serviceability and http client
tests to make sure that they compile with this change?
Yes, I ran tier1,tier2,tier3 tests(I think it includes httpclient
tests), and also specific tests using Utils.getFreePort in svc ar
On 16/03/2018 4:05 PM, Alan Bateman wrote:
On 16/03/2018 01:54, Hamlin Li wrote:
:
Hi Alan,
Thank you for detailed reviewing. I have updated the webrev in place.
(http://cr.openjdk.java.net/~mli/8199215/webrev.00/)
Looks good, just a minor typo "is better choice" -> "is a better choice".
Hi
On 16/03/2018 01:54, Hamlin Li wrote:
:
Hi Alan,
Thank you for detailed reviewing. I have updated the webrev in place.
(http://cr.openjdk.java.net/~mli/8199215/webrev.00/)
Looks good, just a minor typo "is better choice" -> "is a better choice".
Just to confirm, have you run the serviceabilit
