Re: RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

2018-03-09 Thread Ivan Gerasimov
Hi Chris! Thank you for reviewing the patch set! On 3/9/18 3:50 AM, Chris Hegarty wrote: Ivan, Thanks for breaking up the changes, it makes it easier to review. I disagree with changing DualStackPlainSocketImp to conform with TwoStacks (and unix/PlainSocketImpl). I would prefer to move the la

Re: RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

2018-03-09 Thread Chris Hegarty
Ivan, Thanks for breaking up the changes, it makes it easier to review. I disagree with changing DualStackPlainSocketImp to conform with TwoStacks (and unix/PlainSocketImpl). I would prefer to move the latter to the former. Specifically, around the use of fdAccess. -Chris. On 06/03/18 20:31,