Hi Chris,
Thanks for review, while my testing i discovered issue in the way we
handle extended socket options and standard socket options. I fixed it
and updated one test as well.
I removed one redundant "if check" which i think not required. JPRT is
clean with the changed code.
Please fi
Looks good Chris.
- Michael.
On 24/11/2017, 17:05, Chris Hegarty wrote:
Just an update on this.
There have been many review comments, off line, that have resulted in
changes pushed to the sandbox, so I've refreshed the webrev at the
same location.
http://cr.openjdk.java.net/~chegar/http_clien
Hi Chris,
Thanks for taking on the changes.
The webrev looks good.
best regards,
-- daniel
On 30/11/2017 13:00, Chris Hegarty wrote:
Thanks for the review Daniel.
On 28 Nov 2017, at 18:22, Daniel Fuchs wrote:
Hi Chris,
Thanks for refreshing the webrev with our internal feedback.
You’re
Thanks for the review Daniel.
> On 28 Nov 2017, at 18:22, Daniel Fuchs wrote:
>
> Hi Chris,
>
> Thanks for refreshing the webrev with our internal feedback.
You’re welcome.
> I believe there are still some cleanup we could do to
> wean out some more dead code (for instance I believe
> Excepti
