Re: RFR[10]: JDK-8023649 - java.net.NetworkInterface.getInterfaceAddresses() call flow clean up

2017-09-12 Thread vyom tewari
Hi Mark, Thanks for doing this, i see that "createNetworkInterface" method is getting called from multiple places in NetworkInterface.c there is pending JNI Exception at line 695 in NetworkInterface.c. I am not sure if it is safe to call "(*env)->ReleaseStringUTFChars" even if there is pendin

RFR[10]: JDK-8023649 - java.net.NetworkInterface.getInterfaceAddresses() call flow clean up

2017-09-12 Thread Mark Sheppard
Hi,     please oblige and review the follows changes: http://cr.openjdk.java.net/~msheppar/8023649/webrev/ for the issue: https://bugs.openjdk.java.net/browse/JDK-8023649 This is performed under the auspices of reliability, robustness and stability. * As such, a number of error checks are amen

Re: RFR[10]:8159526 Deprivilege jdk.httpserver

2017-09-12 Thread Chris Hegarty
> On 12 Sep 2017, at 09:46, vyom tewari wrote: > > On Tuesday 12 September 2017 02:12 PM, Alan Bateman wrote: >> On 12/09/2017 09:06, vyom tewari wrote: >>> Hi, >>> >>> Please review the below code change. >>> >>> BugId: https://bugs.openjdk.java.net/browse/JDK-8159526 >>> >>> Webrev-1: http: