Re: RFR 8166139/10, Refactor java/net shell cases to java

2017-05-29 Thread Felix Yang
Hi Chris, please review the updated webrev below. Comments inline. http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.03/ -Felix On 2017/5/29 18:19, Chris Hegarty wrote: Felix, Thanks for taking this one. A few comments: 1) test/java/net/URLConnection/6212146/TestDriver.java Please

Re: RFR 8166139/10, Refactor java/net shell cases to java

2017-05-29 Thread Chris Hegarty
Felix, Thanks for taking this one. A few comments: 1) test/java/net/URLConnection/6212146/TestDriver.java Please check indentation around L81: 80 Files.copy(testJar, ___targetDir.resolve(ARCHIVE_NAME), 81 ___StandardCopyOption.REPLACE_EXISTIN