Re: 9 RFR: 8178147: Race conditions in timeout handling code in http/2 incubator client

2017-04-07 Thread Chris Hegarty
> On 7 Apr 2017, at 17:51, Daniel Fuchs wrote: > > Hi Chris, > > Here is the new webrev - where I have incorporated your feedback. > > http://cr.openjdk.java.net/~dfuchs/webrev_8170940/webrev.01/ Looks good to me Daniel. -Chris.

Re: 9 RFR: 8178147: Race conditions in timeout handling code in http/2 incubator client

2017-04-07 Thread Daniel Fuchs
Hi Chris, Here is the new webrev - where I have incorporated your feedback. http://cr.openjdk.java.net/~dfuchs/webrev_8170940/webrev.01/ If I don't hear from you that's what I plan to push on Monday. best regards, -- daniel On 07/04/2017 15:12, Daniel Fuchs wrote: On 07/04/2017 14:31, Chris

Re: 9 RFR: 8178147: Race conditions in timeout handling code in http/2 incubator client

2017-04-07 Thread Daniel Fuchs
On 07/04/2017 14:31, Chris Hegarty wrote: Daniel, On 06/04/17 11:32, Daniel Fuchs wrote: ... webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8170940/webrev.00/ Looks good Daniel. Just a few comments. 1) Http1Exchange.java Can 'operations' now be made private, and not a synchronizedList

Re: 9 RFR: 8178147: Race conditions in timeout handling code in http/2 incubator client

2017-04-07 Thread Chris Hegarty
Daniel, On 06/04/17 11:32, Daniel Fuchs wrote: ... webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8170940/webrev.00/ Looks good Daniel. Just a few comments. 1) Http1Exchange.java Can 'operations' now be made private, and not a synchronizedList? Now that it is operated on only within