Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2016-12-23 Thread Chris Hegarty
> On 23 Dec 2016, at 15:06, Thomas Stüfe wrote: > > On Fri, Dec 23, 2016 at 11:25 AM, Volker Simonis > wrote: > On Thu, Dec 22, 2016 at 9:41 PM, Thomas Stüfe > wrote: > > ... > > 1) The naming of the unix...DefaultProxySelector.c

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2016-12-23 Thread Thomas Stüfe
On Fri, Dec 23, 2016 at 11:25 AM, Volker Simonis wrote: > On Thu, Dec 22, 2016 at 9:41 PM, Thomas Stüfe > wrote: > > Hi Arno, > > > > good job, this is a nice addition! > > > > Some remarks/questions (not a full review): > > > > 1) The naming of the unix...DefaultProxySelector.c is confusing. Co

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2016-12-23 Thread Chris Hegarty
Arno, > On 22 Dec 2016, at 16:44, Zeller, Arno wrote: > > Hi Vyom, > > thanks for the comments – now I understand the problem. I reworked all three > platforms to check for exceptions and NULL if needed. > Regarding the JNIReleaseString calls: I seem to be on the save sidether. They > are l

Re: RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

2016-12-23 Thread Volker Simonis
On Thu, Dec 22, 2016 at 9:41 PM, Thomas Stüfe wrote: > Hi Arno, > > good job, this is a nice addition! > > Some remarks/questions (not a full review): > > 1) The naming of the unix...DefaultProxySelector.c is confusing. Could we > rename it to gnome/../DefaultProxySelector? > I don't think that w