Hi Chris,
thanks for the review.
You are right, it looks more consistent if the code would also 'goto
cleanupAndReturn' at getaddrinfo failure. I'll change that before pushing.
For me this one was driven by reducing diffs of our SAP JVM variant to the
master. We did that change already quite s
Hi Christoph,
> On 12 Dec 2016, at 10:09, Langer, Christoph wrote:
>
> Hi again,
>
> this is the Windows part.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8171077
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8171077.0/
I think this looks ok.
For consistency, should the code ‘
Could I get the following API (and impl) change reviewed please?
The change is to add a getter and setter in j.n.URLConnection
for a per-protocol default setting for the useCaches flag. With this
change it will be possible to switch off caching for the jar: protocol
but leave it switched on for h
Hi Chris,
interesting finding - I have to admit that I didn't pay attention to that
detail.
But I think the removed implementation anyway was rather unused and obsolete.
Both, the other version in IPv4 impl and the one in IPv6 impl would not reverse
the order, so nothing should change in behav
Hi Christoph,
On 19/12/16 08:37, Langer, Christoph wrote:
Thanks for the review, Goetz.
I pushed it: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3edecfdfe4de
Sorry I didn't get to this before now. I think the changes are
good. Trivially, the array return by lookupAllHostAddr will now
always b
Thanks for the review, Goetz.
I pushed it: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3edecfdfe4de
Best regards
Christoph
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Freitag, 16. Dezember 2016 11:11
> To: Langer, Christoph ; 'Michael McMahon'
> ; Chris Hegarty
> ; OpenJDK Ne
