Re: httpserver does not close connections when RejectedExecutionException occurs

2016-11-09 Thread Yasumasa Suenaga
Hi Yuji, http://cr.openjdk.java.net/~ykubota/8169358/webrev.01/ I think you can use finally statement to close the connection in this case. Your patch cannot close the connection when any other runtime exceptions are occurred. However, it is concerned double close if custom handler which is

Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

2016-11-09 Thread Daniel Fuchs
On 09/11/16 08:57, Sergei Kovalev wrote: Hi Daniel, Thank you for feedback. Fixed and verified locally. http://cr.openjdk.java.net/~skovalev/8169196/webrev.02/ Looks good - except for using a raw type at line 220: 220 Class ntlmProxyClass should be: Class ntlmP

Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

2016-11-09 Thread Sergei Kovalev
Hi Daniel, Thank you for feedback. Fixed and verified locally. http://cr.openjdk.java.net/~skovalev/8169196/webrev.02/ -- With best regards, Sergei 08.11.16 20:38, Daniel Fuchs wrote: Hi Sergey, This looks good now - except for line 223: 221 Field ntlmSupportedField = ntlmPr