Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

2016-11-08 Thread Daniel Fuchs
Hi Sergey, This looks good now - except for line 223: 221 Field ntlmSupportedField = ntlmProxyClass.getDeclaredField("supported"); 222 ntlmSupportedField.setAccessible(true); 223 if (Boolean.TRUE.equals(ntlmSupportedField.getBoolean(ntlmProxyClass))) {

Re: RFR(s): 8169196: [TESTBUG] Three tests from sun/net/www have undeclared dependencies

2016-11-08 Thread Sergei Kovalev
Hi Daniel, All remarks incorporated into: http://cr.openjdk.java.net/~skovalev/8169196/webrev.01/ Also I've added a note to the https://bugs.openjdk.java.net/browse/JDK-8038079 -- With best regards, Sergei 04.11.16 14:20, Daniel Fuchs wrote: Hi Sergey, Yes - sorry - I misunderstood the p

Re: httpserver does not close connections when RejectedExecutionException occurs

2016-11-08 Thread KUBOTA Yuji
Hi Chris, If I can add reproduce code as test, could you please teach me a hint to add it? Thanks, Yuji. 2016-11-08 18:53 GMT+09:00 KUBOTA Yuji : > Hi Chris, > > Thank you for your review and updating this issues on JBS. > > I filed an issue: > https://bugs.openjdk.java.net/browse/JDK-8169358 >

Re: httpserver does not close connections when RejectedExecutionException occurs

2016-11-08 Thread KUBOTA Yuji
Hi Chris, Thank you for your review and updating this issues on JBS. I filed an issue: https://bugs.openjdk.java.net/browse/JDK-8169358 I don't assign to me because I'm not a committer. 2016-11-08 0:28 GMT+09:00 Chris Hegarty : >> * patch >> diff --git >> a/src/jdk.httpserver/share/classes/sun/