Daniel and Chris,
thanks for the comment, I will push the updated version.
Thanks,
Felix
On 2016/11/2 22:12, Daniel Fuchs wrote:
On 02/11/16 11:18, Chris Hegarty wrote:
Thanks for doing this Felix.
I have some comments about the style and the use of
AccessControlContext.
Rather than list
Hi,
here is the Windows counterpart of 8167420.
Bug: https://bugs.openjdk.java.net/browse/JDK-8167457
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8167457.0/
Mainly I suggest to replace gethostbyaddr/gethostbyname in Inet4AddressImpl.c
to getaddrinfo/getnameinfo - such as Inet6AddressImp
Hi,
I respun my proposal for cleaning up Inet4AddressImpl.c and Inet6AddressImpl.c:
http://cr.openjdk.java.net/~clanger/webrevs/8167420.1/
So, apart from dropping the implementation for the rare AllBSD/MacOS code, I
suggest the following things:
Java_java_net_Inet4AddressImpl_getLocalHostName:
On 02/11/16 11:18, Chris Hegarty wrote:
Thanks for doing this Felix.
I have some comments about the style and the use of AccessControlContext.
Rather than list them I put an alternative version at the following location,
please
take a look.
http://cr.openjdk.java.net/~chegar/8156504_alt/
No
Thanks, Chris.
I pushed it: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/6577fabed061
Best regards
Christoph
> -Original Message-
> From: Chris Hegarty [mailto:chris.hega...@oracle.com]
> Sent: Dienstag, 1. November 2016 14:34
> To: Langer, Christoph
> Cc: net-dev@openjdk.java.net
> Subj
Thanks for doing this Felix.
I have some comments about the style and the use of AccessControlContext.
Rather than list them I put an alternative version at the following location,
please
take a look.
http://cr.openjdk.java.net/~chegar/8156504_alt/
Note: specifically it is good practice to r
Hi Amy,
thanks for the comments. Updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8156504/webrev.01/
-Felix
On 2016/11/2 14:18, Amy Lu wrote:
Good to see one more script test be changed to java, thank you Felix.
I'm not official reviewer, but some minor comments.
30 * @library /li
