RFR 8154525, java/net/ServerSocket/ThreadStop.java fails intermittently with error while cleaning up threads after test

Hi all, please review following test fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8154525 Webrev: http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.00/ This test has been observed to fail sometimes with "Error while cleaning up threads after test ", even after test compl

Re: RFR - 8166747: Add invalid network / computer name cases to isReachable known failure switch

Hi Rob, changes look reasonable ... perhaps align the two additions below the existing ERROR_XXX set, all neat and tidy :-) regards Mark On 27/09/2016 00:09, Rob McKenna wrote: Hi folks, Looking for a review of this simple addition to Inet4AddressImpl.c on Windows. As per the bug report

RFR - 8166747: Add invalid network / computer name cases to isReachable known failure switch

Hi folks, Looking for a review of this simple addition to Inet4AddressImpl.c on Windows. As per the bug report: In the ping4() call in Inet4AddressImpl.c on Windows there is a switch statement containing failure codes for IcmpSendEcho which correspond to well known and expected failures for th

RE: RFR(XS): 8166584: Remove obsolete utility function NET_ThrowSocketException in windows libnet

Hi Chris, I agree with your comment on the NPE. It would probably be wrong. So I restored the old code and also removed the comments suggesting the NPE. Here is my new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8166584.1/ What I was thinking a bit more about after I posted my initial w

Re: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Hi Felix, This looks good to me now. best regards, -- daniel On 26/09/16 15:02, Felix Yang wrote: Hi Daniel, thanks for figuring out this mistake. Put it before return to avoid unclosed socket. Also updated style as Langer suggested. Updated web rev: http://cr.openjdk.java.net/~xi

Re: RFR(XS): 8166584: Remove obsolete utility function NET_ThrowSocketException in windows libnet

Christoph, On 22/09/16 21:59, Langer, Christoph wrote: Hi, while looking at utility functions for creating exceptions in libjava/libnet I found a small spot that should be consolidated right away. The function NET_ThrowSocketException does only exist in the windows native implementation and i

Re: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Hi Daniel, thanks for figuring out this mistake. Put it before return to avoid unclosed socket. Also updated style as Langer suggested. Updated web rev: http://cr.openjdk.java.net/~xiaofeya/8085575_8130657/webrev.01/ Thanks, Felix > On 26 Sep 2016, at 5:29 PM, Daniel Fuchs wrote: > >

Re: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Xuelei, thanks for the information. That is why I stated it is the nature of such scenario. Some of such scenarios look like not avoidable. Thanks, Felix > On 26 Sep 2016, at 5:57 PM, Xuelei Fan wrote: > > Just FYI. > > The intermittent failures look like similar to some anti-free-port usi

Re: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Just FYI. The intermittent failures look like similar to some anti-free-port using issues. In the current testing environment, for the InheritHandle test case, this anti-free-port using issue may looks like: 1. InheritHandle creates a server socket on a free port, and gets the port (PORT-A)

Re: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Hi Felix, InheritHandle.java: 79 } finally { 80 try { 81 ss.close(); 82 } catch (IOException e) { 83 e.printStackTrace(); 84 } 85 } Is finally the right construct here? It seems to me that you're c

RE: RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Hi Felix, looks ok to me, though I'm no reviewer. One nit: test/java/net/MulticastSocket/TimeToLive.java, line 40, you could remove the ';' from the try statement. Best regards Christoph > -Original Message- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Felix >

RFR 8085575_8130657, misc fixes for a few of java.net intermittent failures

Hi there, please review following patch to a few of java.net tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8085575 https://bugs.openjdk.java.net/browse/JDK-8130657 Webrev: http://cr.openjdk.java.net/~xiaofeya/8085575_8130657/webrev.00/ Add retry for java/net/Socket/Inheri