Re: RFR 8166359/9, java/net/URLPermission/nstest/lookup.sh fails if proxy is set, since fix for JDK-8161016

2016-09-20 Thread Felix Yang
Hi Chris, On 2016/9/20 23:22, Chris Hegarty wrote: Felix, On 20 Sep 2016, at 13:57, Felix Yang wrote: Hi all, please review the following test fix. It explicitly disables proxy to make sure the test not affected by different environment configuration. Bug: https://bugs.openjdk.j

Re: [9] RFR: 8164591: sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java failed with SSLHandshakeException

2016-09-20 Thread Artem Smotrakov
Hello, If you don't mind, I moved some common code from SSLSocketTemplate.java to SSLTest.java, so that it can be re-used by other tests. It may help to avoid duplicate code. http://cr.openjdk.java.net/~asmotrak/8164591/webrev.01/ Please take a look. Artem On 09/15/2016 11:49 AM, Artem Sm

Re: RFR 8166359/9, java/net/URLPermission/nstest/lookup.sh fails if proxy is set, since fix for JDK-8161016

2016-09-20 Thread Chris Hegarty
Felix, > On 20 Sep 2016, at 13:57, Felix Yang wrote: > > Hi all, > please review the following test fix. It explicitly disables proxy to > make sure the test not affected by different environment configuration. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8166359 > > Webrev: >

RFR 8166359/9, java/net/URLPermission/nstest/lookup.sh fails if proxy is set, since fix for JDK-8161016

2016-09-20 Thread Felix Yang
Hi all, please review the following test fix. It explicitly disables proxy to make sure the test not affected by different environment configuration. Bug: https://bugs.openjdk.java.net/browse/JDK-8166359 Webrev: http://cr.openjdk.java.net/~xiaofeya/8166359/webrev.00/

Re: RFR(s): 8166285: Missing dependencies java.httpclient for tests from java/net pachage

2016-09-20 Thread Chris Hegarty
> On 19 Sep 2016, at 15:33, Sergei Kovalev wrote: > > Hello team, > > Could you please review below fix for: > > BugID: https://bugs.openjdk.java.net/browse/JDK-8166285 > Webrev: http://cr.openjdk.java.net/~skovalev/8166285/webrev.00/ Reviewed. Thanks Sergei. -Chris. > Issue: Several regres