Re: RFR 8163561, add a test for Proxy Authentication in HTTP/2 Client API

2016-08-18 Thread Chris Hegarty
On 18 Aug 2016, at 10:26, Felix Yang wrote: > > Hi all, > >please review a new test, which tries to verify "Proxy-Authenticate" > header can be handled correctly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8163561 > > Webrev: http://cr.openjdk.java.net/~xiaofeya/8163561/webrev.00/

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Rahman USTA
It is okay, I now clearly understand this usage. Thank you for helping me to understand the WebSocket Client API clearly. Best regards. 2016-08-18 16:16 GMT+03:00 Pavel Rappo : > > > On 18 Aug 2016, at 13:54, Rahman USTA wrote: > > > > A WebSocket server can send any message at any time to any

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Pavel Rappo
> On 18 Aug 2016, at 13:54, Rahman USTA wrote: > > A WebSocket server can send any message at any time to any client, so how a > client will be able to get any message at any time with this API ? For > example, if our server pushes new stock exchange data to our client, how can > I get this m

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Rahman USTA
Ah, it is now okay. I was using Tyrus WebSocket Client and WebSocket message were coming asynchronously without calling webSocket.request(1) like method there. It is something like releasing a lock from semaphore. A WebSocket server can send any message at any time to any client, so how a client w

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Pavel Rappo
> On 18 Aug 2016, at 11:44, Rahman USTA wrote: > > Hmm, how should I refactor it on my code to make it clear? Pardon, I don't think I fully understand the question. In the API you have two _independent_ points where you can start your work. 1. When an instance of WebSocket is ready the Comple

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Rahman USTA
Hmm, how should I refactor it on my code to make it clear? Best regards. 2016-08-18 13:41 GMT+03:00 Pavel Rappo : > > > On 18 Aug 2016, at 11:38, Rahman USTA wrote: > > > > It requests when connection is open, isn't it a right place to start > WebSocket conversation ? > > It's up to you to deci

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Pavel Rappo
> On 18 Aug 2016, at 11:38, Rahman USTA wrote: > > It requests when connection is open, isn't it a right place to start > WebSocket conversation ? It's up to you to decide. Indeed, by default WebSocket requests a single message in WebSocket.Listener.onOpen.

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Rahman USTA
It requests when connection is open, isn't it a right place to start WebSocket conversation ? Thanks 2016-08-18 13:35 GMT+03:00 Pavel Rappo : > This API was designed to work within "reactive pull" model [1]. In other > words, > in order to receive messages you must first request them ( see > Web

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Pavel Rappo
This API was designed to work within "reactive pull" model [1]. In other words, in order to receive messages you must first request them ( see WebSocket.request(long) ). As far as I can see, your code requests nothing. If you want to disable reactive pull completely, you can request Long.MAX_VALUE

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Rahman USTA
Hi Pavel; My WebSocket client is; URI uri = URI.create("ws://localhost:8080/merhaba"); MessageListener messageListener = new MessageListener(); WebSocket.newBuilder(uri, messageListener) .buildAsync() .join(); My MessageListener is here; public c

Re: HTTP/2 Client WebSocket support

2016-08-18 Thread Pavel Rappo
Hi, Though it's not yet complete and some bugs are expected [1], I strongly suspect the reason you don't receive any messages from the server might be due to MessageListener implementation. Could you please post its code? Thanks. ---

HTTP/2 Client WebSocket support

2016-08-18 Thread Rahman USTA
Hello; I try the WebSocket API in java.httpclient module; URI uri = URI.create("ws://localhost:8080/merhaba"); MessageListener messageListener = new MessageListener(); WebSocket.newBuilder(uri, messageListener) .buildAsync() .join(); I have this c

RFR 8163561, add a test for Proxy Authentication in HTTP/2 Client API

2016-08-18 Thread Felix Yang
Hi all, please review a new test, which tries to verify "Proxy-Authenticate" header can be handled correctly. Bug: https://bugs.openjdk.java.net/browse/JDK-8163561 Webrev: http://cr.openjdk.java.net/~xiaofeya/8163561/webrev.00/ Thanks, Felix