Re: RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(null)

2016-07-06 Thread Artem Smotrakov
Hi Svetlana, Thanks for addressing my comments. Could you please take a look at a couple of comments about TestFtpClientNameListWithNull.java below? 1. lines 64-70: should "client" be closed in "finally" block? I also think it might be better to re-throw IOExceptions instead of ignoring them

Re: RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(null)

2016-07-06 Thread Svetlana Nikandrova
Hi Artem, thank you for your replay. I believe I addressed all your comments. Please see updated diff: http://cr.openjdk.java.net/~snikandrova/8022580/webrev.01/ Thank you, Svetlana On 05.07.2016 20:54, Artem Smotrakov wrote: Hi