Re: RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(null)

2016-07-05 Thread Artem Smotrakov
Hi Svetlana, I am not an official reviewer, but I have a couple comments below. TestFtpClientNameListWithNull.java: 1. Shouldn't "commandHasArgs" be volatile? Looks like it may cause intermittent failures. As a sanity check, you may want to run the test in a loop to make sure it is stable.

RFR 8022580: sun.net.ftp.impl.FtpClient.nameList(null)

2016-07-05 Thread Svetlana Nikandrova
Hello, please review this fix for bug https://bugs.openjdk.java.net/browse/JDK-8022580 Webrev: http://cr.openjdk.java.net/~msolovie/8022580/webrev.00/ Description: There is no handling for null path parameter in the method sun.net.ftp.impl.FtpClient#nameList(), while javadoc says that "@pa