Hi Chris, Bernd,
ok, here is the new webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8158023.2/
I reduced the set of changes to do just the following:
1. clean up JNU_ThrowByNameWithLastError a little bit without changing its
behavior, that is just use the last error string representation a
Hi,
On Wed, Jun 1, 2016 at 2:26 PM, Pavel Rappo wrote:
> Simone, may I ask you what you think about current `Listener.onPong()`
> behaviour? Do you think it should also send Pong unconditionally upon
> completion
> of returned CS?
I'm not sure it's worth encouraging to write application data fr
Hi Pavel,
Many good improvements
WebSocket:
- CloseReason.of; line 1187: the new constructor of(ByteBuffer) is
using IllegalArgumentException inappropriately
(And other constructors too)
Since the data some off the wire; it is not really the callers fault
if it is too short or too lo
> On 1 Jun 2016, at 15:17, Pavel Rappo wrote:
>
> On the stream thing, well... If you say it's a rare use case, I say let's hear
> more people. I don't have much experience working with WebSocket as a user,
> so I
> would like to listen to people who have it (like yourself). YAGNI is one of my
Simone,
I'm having second thoughts on it. I think you're right about `onClose`
behaviour.
Moreover I now understand `onPing` should behave similarly.
The only difference is that replying with Pong should not be correlated with an
any feedback (e.g. completion, return, etc.) from `onPing` method
Hi Simone, many thanks for taking a close look at this!
> On 31 May 2016, at 23:05, Simone Bordet wrote:
>
> * What is interface Text for ?
> If it does perform a bytes-to-chars conversion, then offering
> asByteBuffer() can be easily done by the application.
> A websocket implementation must ch
Hi Chris, Bernd,
thanks for your input.
I will remove the change from "java/net/SocketException” to JNU_JAVANETPKG.
Splitting the refacturing of the Throw functions and the call site changes is
generally ok for me. The question is, which way to go with the Throw functions.
NET_ThrowByNameWithL
Christoph,
> On 1 Jun 2016, at 08:33, e...@zusammenkunft.net wrote:
>
> Hello,
>
> Since nobody commented, here is my non binding comment:
>
> I am not sure which Exception call-site actually improved (i.e. added the
> error code)? I would split out the improvement of this/those throws and the
Hi Pavel,
one comment:
http://cr.openjdk.java.net/~prappo/8156742/webrev.01/src/java.httpclient/share/classes/java/net/http/WebSocket.java.udiff.html
The CloseReason is constructed with read only Buffer as following:
+ private CloseReason(WSCloseCode code, String description, ByteBuffer
d
Hello,
Since nobody commented, here is my non binding comment:
I am not sure which Exception call-site actually improved (i.e. added the error
code)? I would split out the improvement of this/those throws and the
refacturing of the code. Personally I would prefer to keep the NET_ variant and
a
10 matches
Mail list logo
