RE: JDK-8148424 Support IPv6-only Unix environments

2016-05-24 Thread Langer, Christoph
Hi, to me the changes look good. I'll take the patch into my queue and do some testing on AIX. Best regards Christoph > -Original Message- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Chris > Hegarty > Sent: Donnerstag, 12. Mai 2016 17:32 > To: Martin Buchholz

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-24 Thread Chris Hegarty
> On 24 May 2016, at 17:21, Svetlana Nikandrova > wrote: > > I hate being annoying, but may be you can find another minute to review > updated diff? This mainly look fine. Some comments: - The test will need to '@build jdk.testlibrary.*’ to ensure that the library classes are compiled.

Re: JDK-8148424 Support IPv6-only Unix environments

2016-05-24 Thread Martin Buchholz
I'm (slowly) working on getting you more ipv6 stuff... On Thu, May 12, 2016 at 8:32 AM, Chris Hegarty wrote: > Martin, > > Promoted by some other changes that are going on, I stumbled > across your proposal for 8148424: "Support IPv6-only Unix > environments” [1][2][3]. > > I think the changes ar

Re: RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

2016-05-24 Thread Svetlana Nikandrova
I hate being annoying, but may be you can find another minute to review updated diff? Thank you, Svetlana On 23.05.2016 19:36, Svetlana Nikandrova wrote: Alan, Chris, thank you for your comments. I've decided to do as Chris suggested and updated existing test test/jdk/net/Sockets/Test.java