Hello,
Please review this for 9.
Stream.getResponse() method can hang because it calls join() method
without any timeout. It would be better if it took into account a
timeout value specified for a connection, and threw HttpTimeoutException
if timeout was reached.
The patch updates Stream.ge
Looks nice, thanks :)
> -Original Message-
> From: Chris Hegarty [mailto:chris.hega...@oracle.com]
> Sent: Donnerstag, 12. Mai 2016 17:36
> To: Langer, Christoph
> Cc: net-dev@openjdk.java.net
> Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c
>
> Pushed, with
On 10 May 2016, at 20:52, e...@zusammenkunft.net wrote:
> Hello,
>
> Love it.
Yes, this is along the same lines as I was thinking.
> Not sure about two things, first of all if there are more test cases
> (especially assertions) needed and
Right. Maybe a new test that, 1) runs in all three mod
Pushed, with a few additional stylistic edits.
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/fe3e1508653e
On 12 May 2016, at 12:00, Langer, Christoph wrote:
> Thanks Chris.
>
> When you finally wrap it up, maybe you want to have a look at one thing which
> I didn't dare to clean up. In line 28
Martin,
Promoted by some other changes that are going on, I stumbled
across your proposal for 8148424: "Support IPv6-only Unix
environments” [1][2][3].
I think the changes are good. I rebased them against the latest
source in jdk9/dev.
http://cr.openjdk.java.net/~chegar/8148424/
I put the cha
Hi Michael,
Is there any reason why you don't throw the wrapped `Throwable`
unconditionally?
Thanks.
@@ -144,14 +144,11 @@
}
}
-static Object getProxy(int port, boolean b) throws Exception {
+static Object getProxy(int port, boolean b) throws Throwable {
try {
On 12 May 2016, at 14:43, Michael McMahon wrote:
> This test is still failing intermittently. The reason is that one of the
> places where BindException
> can be thrown is called by reflection. So, the exception is wrapped in an
> InvocationTargetException
> and needs to be unwrapped.
>
> htt
This test is still failing intermittently. The reason is that one of the
places where BindException
can be thrown is called by reflection. So, the exception is wrapped in
an InvocationTargetException
and needs to be unwrapped.
http://cr.openjdk.java.net/~michaelm/8156801/webrev.1/
Thanks,
Mich
Hello Alan,
If that is the showstopper for moving this change forward, Doychin is part
of the Bulgarian JUG. Which has signed the OCA. I talked to him and he is
fine to let his change pass through JUG's account.
Regards,
Ivan
On May 12, 2016 13:32, "Alan Bateman" wrote:
>
>
> On 12/05/2016 11:2
Thanks Chris.
When you finally wrap it up, maybe you want to have a look at one thing which I
didn't dare to clean up. In line 28 you find:
#if defined(_ALLBSD_SOURCE) && defined(__OpenBSD__)
#include
#endif
But will also be included unconditionally for all platforms in
line 34. So maybe thi
On 11 May 2016, at 22:27, Langer, Christoph wrote:
> Hi again,
>
> I'm done with the new version:
> http://cr.openjdk.java.net/~clanger/webrevs/8156521.1/
>
> I now tried to break lines that are too long and also fixed some other space
> and indentation issues.
>
> To incorporate Mark's sugg
On 12/05/2016 11:25, Langer, Christoph wrote:
Hi Doychin,
thanks for pointing me to this. I was already looking at that part of the code
and know about some gaps. So I'll take this item and open a bug and work on
integrating the proposed change.
I don't see Doychin on the of OCA signatorie
Hi Doychin,
thanks for pointing me to this. I was already looking at that part of the code
and know about some gaps. So I'll take this item and open a bug and work on
integrating the proposed change.
I'll probably be able to start working on this next week. But before that my
fix for Bug 81565
Hi, guys
I see that some of you is working on NetworkInterface.c file.
Just posting this to remind that there is a problem in
NetworkInterface.c when scanning network interfaces on Linux platform.
Here is the initial report from January 2015.
http://mail.openjdk.java.net/pipermail/net-dev/20
14 matches
Mail list logo
