Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi Amy, That's case to case. If a test is using java.logging APIs directly, I declared the module for the test. Otherwise, I didn't. I think that may be more clear. Although a test is using jdk.httpserver, that doesn't mean it also dependents on java.logging. Best regards, John Jiang On 2016

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread Amy Lu
On 4/28/16 12:50 PM, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even though some ones have to declare other modules. + * @modules jdk.httpser

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even though some ones have to declare other modules. Best regards, John Jiang On 2016/4/27 23:07, John Jiang wrote:

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Chris Hegarty
On 27 Apr 2016, at 20:13, Alan Bateman wrote: > On 27/04/2016 10:04, Chris Hegarty wrote: >> On 26 Apr 2016, at 18:21, Alan Bateman wrote: >> >>> I took a second pass over it. One thing that I'm wondering about is whether >>> BaseExtendedSocketOptions + Support should be collapsed into one abs

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Alan Bateman
On 27/04/2016 10:04, Chris Hegarty wrote: On 26 Apr 2016, at 18:21, Alan Bateman wrote: I took a second pass over it. One thing that I'm wondering about is whether BaseExtendedSocketOptions + Support should be collapsed into one abstract class ExtendedSocketOptions (or better name) with 3

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Mandy Chung
> On Apr 27, 2016, at 11:16 AM, Chris Hegarty wrote: > > > On 27 Apr 2016, at 17:27, Mandy Chung wrote: > >> >>> On Apr 27, 2016, at 2:04 AM, Chris Hegarty wrote: >>> >>> This works out quite nice. Webrev updated in-place: >>> http://cr.openjdk.java.net/~chegar/8044773/jdk/ >> >> One com

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Chris Hegarty
On 27 Apr 2016, at 17:27, Mandy Chung wrote: > >> On Apr 27, 2016, at 2:04 AM, Chris Hegarty wrote: >> >> This works out quite nice. Webrev updated in-place: >> http://cr.openjdk.java.net/~chegar/8044773/jdk/ > > One comment on the qualified exports of sun.security.action.GetPropertyAction

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Mandy Chung
> On Apr 27, 2016, at 2:04 AM, Chris Hegarty wrote: > > This works out quite nice. Webrev updated in-place: > http://cr.openjdk.java.net/~chegar/8044773/jdk/ One comment on the qualified exports of sun.security.action.GetPropertyAction to jdk.net module. This is a simple utility method used

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi Alan, Felix, Thanks for your comments. Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.01/ Best regards, John Jiang On 2016/4/27 15:08, John Jiang wrote: Hi, Please review the fix for explicitly declaring module dependencies for java net tests. Issue

Re: RFR: 8087124 HTTP/2 implementation

2016-04-27 Thread Chris Hegarty
On 22 Apr 2016, at 22:51, Michael McMahon wrote: > Hi, > > An updated webrev is available at: > > http://cr.openjdk.java.net/~michaelm/8087124/webrev.2/ > > The main change is the removal of the permanently allocated > two threads per TCP connection (for HTTP/2) This is good. Http2ClientImp

Re: RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

2016-04-27 Thread Chris Hegarty
On 26 Apr 2016, at 18:21, Alan Bateman wrote: > I took a second pass over it. One thing that I'm wondering about is whether > BaseExtendedSocketOptions + Support should be collapsed into one abstract > class ExtendedSocketOptions (or better name) with 3 instance methods and 2 > static methods

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread Alan Bateman
On 27/04/2016 08:08, John Jiang wrote: Hi, Please review the fix for explicitly declaring module dependencies for java net tests. Issue: https://bugs.openjdk.java.net/browse/JDK-8151913 Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00 Since every test in test/java/net/httpclient/*

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread Chris Hegarty
On 27 Apr 2016, at 08:08, John Jiang wrote: > Hi, > Please review the fix for explicitly declaring module dependencies for java > net tests. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8151913 > Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00 This looks ok to me. Thanks,

RFR JDK-8151913: Fix module dependencies in java/net tests

2016-04-27 Thread John Jiang
Hi, Please review the fix for explicitly declaring module dependencies for java net tests. Issue: https://bugs.openjdk.java.net/browse/JDK-8151913 Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00 Best regards, John Jiang