Re: RFR JDK-8087113: Websocket API and implementation

2016-04-10 Thread Martin Buchholz
On Sun, Apr 10, 2016 at 10:19 PM, Andrej Golovnin wrote: >> On Sun, Apr 10, 2016 at 2:00 PM, Andrej Golovnin >> wrote: >>> BTW, someone should describe in the JavaDocs of >>> CompletableFuture#orTimeout() >>> what would happen when this method is called multiple times on the same >>> Completable

Re: RFR JDK-8087113: Websocket API and implementation

2016-04-10 Thread Andrej Golovnin
> On Sun, Apr 10, 2016 at 2:00 PM, Andrej Golovnin > wrote: >> BTW, someone should describe in the JavaDocs of CompletableFuture#orTimeout() >> what would happen when this method is called multiple times on the same >> CompletableFuture with different arguments. > > Hmmm the javadoc seems clear en

Re: RFR JDK-8087113: Websocket API and implementation

2016-04-10 Thread Martin Buchholz
On Sun, Apr 10, 2016 at 2:00 PM, Andrej Golovnin wrote: > BTW, someone should describe in the JavaDocs of CompletableFuture#orTimeout() > what would happen when this method is called multiple times on the same > CompletableFuture with different arguments. Hmmm the javadoc seems clear enough to me

Re: RFR JDK-8087113: Websocket API and implementation

2016-04-10 Thread Andrej Golovnin
Hi Pavel, I’m sorry for the late response. I was too busy this week. > Maybe we could somehow melt what you call CloseReason and CloseCode into a > single entity? Something like (different name is an option too): > >public final class CloseReason { > >static CloseReason normalClosur