Re: RFR JDK-8087113: Websocket API and implementation

2016-04-06 Thread Pavel Rappo
> On 4 Apr 2016, at 18:16, Anthony Vanelverdinghe > wrote: > >>> - CompletableFuture sendClose(CloseCode code, CharSequence reason) >>> change the type of "reason" to String >> What's the rationale behind this? > Unlike with the sendText methods, I don't see the added value here. For > example

Re: RFR JDK-8153353: HPACK implementation

2016-04-06 Thread Vitaly Davidovich
On Wednesday, April 6, 2016, Pavel Rappo wrote: > Hi again Simone :-) > > > On 6 Apr 2016, at 20:31, Simone Bordet > wrote: > > > > 1) Add a test for the decoder where you have the incoming bytes be > > passed 1 at the time to the decoder. > > Something like: > > > > ByteBuffer data = ByteBuffer

Re: RFR JDK-8153353: HPACK implementation

2016-04-06 Thread Pavel Rappo
Hi again Simone :-) > On 6 Apr 2016, at 20:31, Simone Bordet wrote: > > 1) Add a test for the decoder where you have the incoming bytes be > passed 1 at the time to the decoder. > Something like: > > ByteBuffer data = ByteBuffer.wrap(new byte[]{ >0b, // literal, index=15

Re: RFR JDK-8087113: Websocket API and implementation

2016-04-06 Thread Roger Riggs
Hi Pavel, On 4/5/2016 2:27 PM, Pavel Rappo wrote: Hi Roger, thanks for looking into this. On 5 Apr 2016, at 17:37, Roger Riggs wrote: It would be helpful if the classnames/filenames reflected the participation in the WebSocket implementation to keep them distinct from the HTTP 2.0 implemen

Re: RFR JDK-8153353: HPACK implementation

2016-04-06 Thread Simone Bordet
Hi, On Wed, Apr 6, 2016 at 8:00 PM, Pavel Rappo wrote: > Hi, > > Could you please review my change for JDK-8153353? > > http://cr.openjdk.java.net/~prappo/8153353/webrev.00/ > > This is an implementation of HPACK (Header Compression for HTTP/2) [1] > Internal API classes are (package sun.net.http

RFR JDK-8153353: HPACK implementation

2016-04-06 Thread Pavel Rappo
Hi, Could you please review my change for JDK-8153353? http://cr.openjdk.java.net/~prappo/8153353/webrev.00/ This is an implementation of HPACK (Header Compression for HTTP/2) [1] Internal API classes are (package sun.net.httpclient.hpack): Encoder, Decoder and DecodingCallback Example of

Re: RFR: 8087124 HTTP/2 implementation

2016-04-06 Thread Michael McMahon
John, It is not necessary to have access to the frames themselves to achieve this. At the API level, in the HttpResponse.MultiProcessor type the onStart() method returns a BiFunction that is called for each incoming push promise. The implementation of that function (which is supplied by the use

Re: RFR: 8087124 HTTP/2 implementation

2016-04-06 Thread John Jiang
Hi Michael, All of HTTP/2 frame types aren't public APIs, then is there any way to handle HTTP/2 at lower level? For example, how to cancel server push? In theory, the client should send a RST_STREAM frame with error code REFUSED_STREAM or CANCEL to the server. Best regards, John Jiang On 20

RFR: 8087124 HTTP/2 implementation

2016-04-06 Thread Michael McMahon
Hi, This is the webrev for the HTTP/2 part of JEP 110. http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/index.html There are minor changes to existing classes as well as the bulk of the new stuff in the new files. Most of the HTTP/2 implementation is in the files: || src/java.httpclient/s

Re: RFR JDK-8087113: Websocket API and implementation

2016-04-06 Thread Chris Hegarty
On 6 Apr 2016, at 09:37, Simone Bordet wrote: > Hi, > > On Tue, Apr 5, 2016 at 11:06 PM, Pavel Rappo wrote: >> Let's suppose we have a ByteBuffer to send. This ByteBuffer contains 1 MB of >> data, the socket send buffer is 16 KB, the network is not particularly fast. >> Suppose then the first

Re: RFR JDK-8087113: Websocket API and implementation

2016-04-06 Thread Simone Bordet
Hi, On Tue, Apr 5, 2016 at 11:06 PM, Pavel Rappo wrote: > Let's suppose we have a ByteBuffer to send. This ByteBuffer contains 1 MB of > data, the socket send buffer is 16 KB, the network is not particularly fast. > Suppose then the first pass fills the full buffer's 16Kb completely. So > WebSock