Re: RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 09:40, Vyom Tewari wrote: > i need sponsor for this fix as well. Pushed: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/eb5798a009cc -Chris. > Vyom > > On 3/3/2016 2:34 PM, Chris Hegarty wrote: >> On 3 Mar 2016, at 05:33, Vyom Tewari wrote: >> >>> incorporated the review co

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 09:39, Vyom Tewari wrote: > i need sponsor for this fix. I pushed this: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/49781476b709 , with a few additional modifications: 1) Unrelated; added missing @since tags to impl supportedOptions ( these were missing when the meth

Re: [DONG] Re: [DING] Re: [PING] Potential infinite waiting at JMXConnection#createConnection

2016-03-03 Thread KUBOTA Yuji
Hi all, Could someone please review this patch? Thanks, Yuji 2016-02-09 15:50 GMT+09:00 KUBOTA Yuji : > Hi David, > > Thank you for your advice and cc-ing! > > I do not have any role yet, so I paste my patches as below. > > diff --git a/src/java.rmi/share/classes/sun/rmi/transport/tcp/TCPChannel

Re: RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets

2016-03-03 Thread Vyom Tewari
i need sponsor for this fix as well. Vyom On 3/3/2016 2:34 PM, Chris Hegarty wrote: On 3 Mar 2016, at 05:33, Vyom Tewari wrote: incorporated the review comment, updated webrev in place. http://cr.openjdk.java.net/~nkumar/vyom/8150521/webrev0.1/index.html

Re: RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 09:40, Vyom Tewari wrote: > i need sponsor for this fix as well. I will sponsor this for you. -Chris. > Vyom > > On 3/3/2016 2:34 PM, Chris Hegarty wrote: >> On 3 Mar 2016, at 05:33, Vyom Tewari wrote: >> >>> incorporated the review comment, updated webrev in place. >>>

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 09:39, Vyom Tewari wrote: > i need sponsor for this fix. I will sponsor this for you. -Chris. > Vyom > > On 3/3/2016 2:37 PM, Alan Bateman wrote: >> >> >> On 03/03/2016 09:03, Chris Hegarty wrote: >>> On 3 Mar 2016, at 05:36, Vyom Tewari wrote: >>> please find the u

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Vyom Tewari
i need sponsor for this fix. Vyom On 3/3/2016 2:37 PM, Alan Bateman wrote: On 03/03/2016 09:03, Chris Hegarty wrote: On 3 Mar 2016, at 05:36, Vyom Tewari wrote: please find the updated webrev http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Alan Bateman
On 03/03/2016 09:03, Chris Hegarty wrote: On 3 Mar 2016, at 05:36, Vyom Tewari wrote: please find the updated webrev http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ Looks fine. Looks okay to me too. -Alan

Re: RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 05:33, Vyom Tewari wrote: > incorporated the review comment, updated webrev in place. > > http://cr.openjdk.java.net/~nkumar/vyom/8150521/webrev0.1/index.html > Looks fine. -Chris. > Vyom > > On 3/2/

Re: RFR 8148609: supportedOptions() methods return a mutable set

2016-03-03 Thread Chris Hegarty
On 3 Mar 2016, at 05:36, Vyom Tewari wrote: > please find the updated webrev > > http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ > Looks fine. -Chris. > Thanks, > Vyom > > > On 3/2/2016 2:36 PM, Chris Hegarty wrote: