Re: RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

2016-01-06 Thread Felix Yang
Thanks Chris! I will remove bug id as you suggested. TO Frank, could you sponsor the fix? Thanks, Felix On 2016/1/6 17:56, Chris Hegarty wrote: Thank Felix. On 06/01/16 08:27, Felix Yang wrote: Hi Chris, updated webrev with your suggestion: http://cr.openjdk.java.net/~xiaofeya/8140

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2016-01-06 Thread Alan Bateman
On 06/01/2016 15:37, Mark Sheppard wrote: thanks for the feedback, Alan based on suggestions, all issues have been addressed and patch has been updated http://cr.openjdk.java.net/~msheppar/8134577/webrev.07 the following should be noted: ExtensionsWithLDAP.java is added to the exclude list

Re: RFR: 8146526: Improve java.net.URI$Parser startup characteristics

2016-01-06 Thread Claes Redestad
On 2016-01-06 08:43, Alan Bateman wrote: On 05/01/2016 22:47, Claes Redestad wrote: Hi, please review this patch to cleanup URI$Parser to help URI construction when run with the interpreter, mostly by inlining wrapping methods: Bug: https://bugs.openjdk.java.net/browse/JDK-8146526 Webrev:

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2016-01-06 Thread Mark Sheppard
thanks for the feedback, Alan based on suggestions, all issues have been addressed and patch has been updated http://cr.openjdk.java.net/~msheppar/8134577/webrev.07 the following should be noted: ExtensionsWithLDAP.java is added to the exclude list with JDK-8134577 - This is on the problem

Re: Patch for adding SO_REUSEPORT socket option

2016-01-06 Thread Alan Bateman
On 05/01/2016 18:56, Lu, Yingqi wrote: Hi Alan, Sorry for the confusion. Let me be more detailed on the issue. In previous version of the patch, I added an initializer in SocketImpl.java to load the libnet.so since the isReusePortAvailable and its native implementation were there. Then, thi

Re: RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

2016-01-06 Thread Chris Hegarty
Thank Felix. On 06/01/16 08:27, Felix Yang wrote: Hi Chris, updated webrev with your suggestion: http://cr.openjdk.java.net/~xiaofeya/8140472/webrev.01/ These changes look ok to me. Trivially, I'd drop the addition of the bugId from the @bug tag, since the test is not exercising 8140472

Re: RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

2016-01-06 Thread Felix Yang
Hi Chris, updated webrev with your suggestion: http://cr.openjdk.java.net/~xiaofeya/8140472/webrev.01/ Thanks, Felix On 2016/1/6 13:49, Chris Hegarty wrote: Hi Felix, On 6 Jan 2016, at 05:09, Felix Yang wrote: Hi all, please review the fix for java/net/ipv6tests/TcpTest.java, whic