Re: RFR: 8146526: Improve java.net.URI$Parser startup characteristics

On 05/01/2016 22:47, Claes Redestad wrote: Hi, please review this patch to cleanup URI$Parser to help URI construction when run with the interpreter, mostly by inlining wrapping methods: Bug: https://bugs.openjdk.java.net/browse/JDK-8146526 Webrev: http://cr.openjdk.java.net/~redestad/81465

Re: RFR(XS): 8146482: [TESTBUG] java/net/SocketOption/OptionTest should only use multicast capable interfaces for multicast tests

Hi Volker, On 5 Jan 2016, at 17:49, Volker Simonis wrote: > Hi, > > can somebody please review this small test fix: > > http://cr.openjdk.java.net/~simonis/webrevs/2016/8146482/ > https://bugs.openjdk.java.net/browse/JDK-8146482 This change looks good to me. -Chris. > The java/net/SocketOpt

Re: RFR: 8146526: Improve java.net.URI$Parser startup characteristics

On 5 Jan 2016, at 22:47, Claes Redestad wrote: > Hi, > > please review this patch to cleanup URI$Parser to help URI construction when > run with the interpreter, mostly by inlining wrapping methods: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8146526 > > Webrev: http://cr.openjdk.java.n

Re: RFC on 8146041: java.net.URLConnection.guessContentTypeFromStream() does not recognize TIFF streams

On 6 Jan 2016, at 02:22, Brian Burkhalter wrote: > This core-libs-dev RFR > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-December/037847.html > > was already approved on core-libs-dev but I would like to make sure there is > no objection from the net-dev community. No objectio

Re: RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

Hi Felix, On 6 Jan 2016, at 05:09, Felix Yang wrote: > Hi all, >please review the fix for java/net/ipv6tests/TcpTest.java, which replaces > hard-coded ports with dynamic free ports on runtime. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8140472 > Webrev: http://cr.openjdk.java.net/~x

RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

Hi all, please review the fix for java/net/ipv6tests/TcpTest.java, which replaces hard-coded ports with dynamic free ports on runtime. Bug: https://bugs.openjdk.java.net/browse/JDK-8140472 Webrev: http://cr.openjdk.java.net/~xiaofeya/8140472/webrev.00 Thanks, Felix

RFC on 8146041: java.net.URLConnection.guessContentTypeFromStream() does not recognize TIFF streams

This core-libs-dev RFR http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-December/037847.html was already approved on core-libs-dev but I would like to make sure there is no objection from the net-dev community. Thanks, Brian

RFR: 8146526: Improve java.net.URI$Parser startup characteristics

Hi, please review this patch to cleanup URI$Parser to help URI construction when run with the interpreter, mostly by inlining wrapping methods: Bug: https://bugs.openjdk.java.net/browse/JDK-8146526 Webrev: http://cr.openjdk.java.net/~redestad/8146526/webrev.01 This is motivated by Jigsaw whe

RE: Patch for adding SO_REUSEPORT socket option

Hi Alan, Sorry for the confusion. Let me be more detailed on the issue. In previous version of the patch, I added an initializer in SocketImpl.java to load the libnet.so since the isReusePortAvailable and its native implementation were there. Then, this time, I tried to move isReusePortAvailabl

RFR(XS): 8146482: [TESTBUG] java/net/SocketOption/OptionTest should only use multicast capable interfaces for multicast tests

Hi, can somebody please review this small test fix: http://cr.openjdk.java.net/~simonis/webrevs/2016/8146482/ https://bugs.openjdk.java.net/browse/JDK-8146482 The java/net/SocketOption/OptionTest test chooses the first network interface returned by NetworkInterface.getNetworkInterfaces() for doi

Re: Patch for adding SO_REUSEPORT socket option

Hi Lucy, I've just looked at the javadoc of MulticastSocket. It has this sentence: * When the socket is created the * {@link DatagramSocket#setReuseAddress(boolean)} method is * called to enable the SO_REUSEADDR socket option. but it doesn't mention SO_REUSEPORT. Could you please

Re: Patch for adding SO_REUSEPORT socket option

On 05/01/2016 04:32, Lu, Yingqi wrote: Hi Alan/Volker, I just found out that the code works by adding the same static block (net library loading) into SocketImpl.java although isReusePortAvailable() is being defined in its subclass AbstractPlainSocketIml.java. I use a print statement to con

Re: Patch for adding SO_REUSEPORT socket option

On 04/01/2016 19:24, Volker Simonis wrote: On Mon, Jan 4, 2016 at 8:02 PM, Lu, Yingqi wrote: : 2. Regarding to the code snippet in net_util_md.c, the reason I check for ENOPROTOOPT is to enable SO_REUSEPORT in the situation that the feature is supported but something else happens during se

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

On 05/01/2016 00:54, Mark Sheppard wrote: Hi, as per feedback below webrev has been updated http://cr.openjdk.java.net/~msheppar/8134577/webrev.06/ change summary: * List nameServices replaced with Nameservice nameService * references to nameServices removed * private interface NameServic