RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
Hi Alan/Volker, I just found out that the code works by adding the same static block (net library loading) into SocketImpl.java although isReusePortAvailable() is being defined in its subclass AbstractPlainSocketIml.java. I use a print statement to confirm that both static blocks from SocketImp

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2016-01-04 Thread Mark Sheppard
Hi, as per feedback below webrev has been updated http://cr.openjdk.java.net/~msheppar/8134577/webrev.06/ change summary: * List nameServices replaced with Nameservice nameService * references to nameServices removed * private interface NameService added, with two implementation PlatformN

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
One more question, we tried to move the isReusePortAvailable() from SocketImpl.java to AbstractPlainSocketImpl.java. However, we found out the static block (attached below) inside the AbstractPlainSocketImpl.java never being executed when the AbstractPlainSocketImpl.isReusePortAvailable() is ca

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Volker Simonis
On Mon, Jan 4, 2016 at 8:24 PM, Alan Bateman wrote: > > > On 04/01/2016 18:43, Volker Simonis wrote: >> >> : >> Alan, what do you mean by "unknown" platform? Currently, as far as I >> know, 0x0200 is used by AIX and MacOS X. Do you suggest to name these >> platforms explicitly and set it to 0 othe

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Volker Simonis
On Mon, Jan 4, 2016 at 8:02 PM, Lu, Yingqi wrote: > Hi Volker, > > Happy New Year and welcome back! Based on the feedback from you and Alan, > here is what I plan to do. Please let me know if you have any concerns. > > 1. I will make HPUX, MACOSX and AIX as known and set them to 0x0200. As > pre

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Alan Bateman
On 04/01/2016 18:43, Volker Simonis wrote: : Alan, what do you mean by "unknown" platform? Currently, as far as I know, 0x0200 is used by AIX and MacOS X. Do you suggest to name these platforms explicitly and set it to 0 otherwise? Leaving the default at 0x0200 has the advantage that it would i

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
Hi Volker, Happy New Year and welcome back! Based on the feedback from you and Alan, here is what I plan to do. Please let me know if you have any concerns. 1. I will make HPUX, MACOSX and AIX as known and set them to 0x0200. As previous, Linux is set to 15 and Solaris is set to 0x100. The rest

Re: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Volker Simonis
Hi Lucy, Alan, I'm back from vacation so here we go :) On Fri, Jan 1, 2016 at 12:18 PM, Alan Bateman wrote: > > On 21/12/2015 17:53, Lu, Yingqi wrote: >> >> Hi All, >> >> Sorry for the late reply. Here is the link to the most recent reversion of >> the patch (version #6). >> http://cr.openjdk.

Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2016-01-04 Thread Artem Smotrakov
Hi Michael, On 01/04/2016 02:28 AM, Michael McMahon wrote: On 30/12/15 03:22, Artem Smotrakov wrote: Hi Michael, Thanks for review, it looks like BNF notation uses only a comma as a separator http://www.w3.org/Notation.html ... #element indicating at least l and at most m elements, each s

Re: [9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

2016-01-04 Thread Michael McMahon
On 30/12/15 03:22, Artem Smotrakov wrote: Hi Michael, Thanks for review, it looks like BNF notation uses only a comma as a separator http://www.w3.org/Notation.html ... #element indicating at least l and at most m elements, each separated by one or more commas (","). ... Hi Artem, The