On 10/6/2015 7:42 AM, David M. Lloyd wrote:
I didn't reply on this last week, but this looks workable to me. Thanks!
Thanks to you guys for all the discussion!
During the architectural review, it was pointed out that the
SSLParameters.setApplicationProtocols() API proposal with the
server-
Here is an update.
Changes are already completed locally. All the tests passed on an old Linux
kernel 3.4.110 which does not have SO_REUSEPORT. Same tests are done on Linux
4.2 kernel before.
Here are the quick information on the current implementation:
1. For multicast socket, SO_REUSE
Sounds good Mark, will do pre-push, cheers.
-Rob
On 25/11/15 18:27, Mark Sheppard wrote:
yes, the fix looks fine, and I verified the individual isReachable test
on the test host where it failed.
it is possible to refactor the function
Java_java_net_Inet4AddressImpl_isReachable0
a lit
yes, the fix looks fine, and I verified the individual isReachable test
on the test host where it failed.
it is possible to refactor the function
Java_java_net_Inet4AddressImpl_isReachable0
a little, by extracting the newly re-introduced "else" block into its
own function
e.g. wxp_ping4
su
Yes, it should work! I already located the issues. Good catch!
I will submit an update as soon as possible.
Thanks,
Lucy
From: Volker Simonis [mailto:volker.simo...@gmail.com]
Sent: Wednesday, November 25, 2015 12:17 PM
To: Lu, Yingqi
Cc: Michael McMahon ; Alan Bateman
; Kharbas, Kishor ;
net
forgot to cc net-dev
-Rob
On 24/11/15 16:37, Rob McKenna wrote:
Hi folks,
The recently updated ICMP (8133015) code fails on Windows XP due to a
missing api. This fix allows XP to fall back to the old tcp based method:
https://bugs.openjdk.java.net/browse/JDK-8141260
http://cr.openjdk.
Yes, I indeed tested on an old kernel - but that should still work after
your change!
On Wednesday, November 25, 2015, Lu, Yingqi wrote:
> Hi Volker,
>
> Thanks very much for letting me know. I actually took the related
> regression tests and they all passed. I think you tested on an old kernel
Hi Volker,
Thanks very much for letting me know. I actually took the related regression
tests and they all passed. I think you tested on an old kernel which does not
have SO_REUSEPORT enabled. In this case, it should not set the flag.
Let me double check. I will get back to you as soon as I can
Hi Lucy,
I took a brief look at your changes but there seems to be something
not right. I can't understand for example why you unconditionally try
to set SO_REUSEPORT on all sockets in Java_sun_nio_ch_Net_socket0() ?
Also which your changes applied, simple regression tests like
test/java/net/Sock
Looks ok to me Rob and provides a re-introduction of the old
Java_java_net_Inet4AddressImpl_isReachable0 function for XP systems
where necessary. Reviewed.
Approved for jdk8u-dev also.
Regards,
Sean.
On 25/11/15 14:00, Rob McKenna wrote:
forgot to cc net-dev
-Rob
On 24/11/15 16:37, Rob
10 matches
Mail list logo
