Hi,
is there someone how wants to support me by making a patch for
JDK-8022748[1]
be available for review on cr.openjdk.net?
I placed my webrev here:
https://dl.dropboxusercontent.com/u/43692695/oss-patches/openjdk/JDK-8022748_0/webrev.zip
Thanks
Sebastian
Am 10.09.2015 um 07:41 schrieb Sebasti
Hi Vyom,
I will sponsor your change and push the fix for you.
I'll sync up with Rob to check that we don't step on each other's toes.
best regards,
-- daniel
On 16/09/15 16:03, Chris Hegarty wrote:
The changes look good to me Vyom.
-Chris.
On 16/09/15 10:08, Vyom Tewari wrote:
Hi All,
Ple
Hi,
here is the updated webrev:
http://cr.openjdk.java.net/~dbuck/4906983.3/
Hope the comments are fine now.
What would be the normal procedure in net-dev for accepting a change (a
2 group-member thumbs-up like in core-libs)?
-- Sebastian
Am 14.09.2015 um 10:53 schrieb Chris Hegarty:
> On 1
The changes look good to me Vyom.
-Chris.
On 16/09/15 10:08, Vyom Tewari wrote:
Hi All,
Please review my changes for below bug.
Bug:
JDK-8073542 : File Leak in
jdk/src/java/base/unix/native/libnet/PlainDatagramSocketImpl.c
Webrev:
http://cr.openjdk.java.net/~dfuchs/vyom/8073542/webrev.
Hi Vyom!
The change looks fine, thanks.
You've used strerr() to extract the error string, so it may be good to
coordinate your patch with the fix for JDK-8133249.
Robert (CCed) is working on it at the moment.
Sincerely yours,
Ivan
On 16.09.2015 12:08, Vyom Tewari wrote:
Hi All,
Please revi
Hi All,
Please review my changes for below bug.
Bug:
JDK-8073542 : File Leak in
jdk/src/java/base/unix/native/libnet/PlainDatagramSocketImpl.c
Webrev:
http://cr.openjdk.java.net/~dfuchs/vyom/8073542/webrev.00
This change ensure that if "setsocketopt" fails we close the
corresponding fd
