RFR: JDK-8022748 (new URI(u.toString()).equals(u),does not hold with paths containing colons

2015-09-09 Thread Sebastian Sickelmann
Hi, i investigated the problem described in JDK-8022748[1] i found that we need to rescue the parser for confusion while parsing relative URIs. A URI created through the relativize-method is schemaless and so it need to handle the special-case (a colon in the path-element). While there is another

URI javadoc failure and "reletivize and resolve"

2015-09-09 Thread Sebastian Sickelmann
Hi, while investigation for JDK-8022748 [1] (new URI(u.toString()).equals(u) does not hold with paths containing colons i found some smaller things. The javadoc contains the following example --- *This operation is often useful when constructing a document containing URIs that must be m

Re: RFR 8080402: File Leak in jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java

2015-09-09 Thread Daniel Fuchs
On 09/09/15 17:54, Mark Sheppard wrote: Hi Vyom, yes, I believe the consensus is to proceed with the changes. OK - I will be pushing them then. best regards, -- daniel regards Mark On 09/09/2015 16:23, Vyom Tewari wrote: Hi Mark, Is it OK to go ahead with the patch as it is, or you

[8u-dev] Request for review and for approval to backport: 8072466: Deadlock when initializing MulticastSocket and DatagramSocket

2015-09-09 Thread Ivan Gerasimov
Hello! I'd like to backport this recent fix from jdk9 to jdk8u-dev. The fix applies *almost* cleanly after unshuffling. The only manual editing I had to do was creating Java_java_net_DualStackPlainDatagramSocketImpl_initIDs() function in DualStackPlainDatagramSocketImpl.c, which didn't exist in

Re: WebSocket client API

2015-09-09 Thread Pavel Rappo
Hi Simone, thanks. I'm currently looking into this. > On 8 Sep 2015, at 21:18, Simone Bordet wrote: > > Hi, > > On Tue, Sep 8, 2015 at 8:34 PM, Pavel Rappo wrote: >> Hi Simone, thanks for looking at this! >> >>> On 8 Sep 2015, at 17:29, Simone Bordet wrote: >>> >>> Uh, please no. >>> >>> J

Re: RFR 8080402: File Leak in jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java

2015-09-09 Thread Mark Sheppard
Hi Vyom, yes, I believe the consensus is to proceed with the changes. regards Mark On 09/09/2015 16:23, Vyom Tewari wrote: Hi Mark, Is it OK to go ahead with the patch as it is, or you are expecting any additional modification is required ?. Thanks, Vyom On 9/8/2015 6:35 PM, Mark Shep

Re: RFR 8080402: File Leak in jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java

2015-09-09 Thread Vyom Tewari
Hi Mark, Is it OK to go ahead with the patch as it is, or you are expecting any additional modification is required ?. Thanks, Vyom On 9/8/2015 6:35 PM, Mark Sheppard wrote: that's true, the documentation is a bit nebulous on this issue. but the inference is that the file descriptors are in