Hi Sebastian,
On 8/09/2015 1:54 PM, Sebastian Sickelmann wrote:
Hi,
please find the link to the webrev[1] hosted at my dropbox in my first mail in
this thread at the buttom of this mail.
A direkt link to the including patch file can be found here:
https://dl.dropboxusercontent.com/u/43692695
Hi,
please find the link to the webrev[1] hosted at my dropbox in my first mail in
this thread at the buttom of this mail.
A direkt link to the including patch file can be found here:
https://dl.dropboxusercontent.com/u/43692695/oss-patches/openjdk/JDK-4906983/jdk.patch
-- Sebastian
Am 08.09
Hi,
i think my first sugesstion was false. While it seems that we can fix
the symptom by changing the final
URI-creation in relativize through reparsing we need to be sure that the
relativize doesn't change to
intension of the original url (which is an absolute path without an shema).
I think the
Oh - sorry - I hadn't seen Mark question.
I will wait until those are resolved...
On 07/09/15 19:24, Daniel Fuchs wrote:
Hi Vyom,
I will sponsor that and push it for you.
best regards,
-- daniel
On 07/09/15 18:52, Alan Bateman wrote:
On 07/09/2015 14:08, Vyom Tewari wrote:
Hi All,
Ple
Hi Vyom,
I will sponsor that and push it for you.
best regards,
-- daniel
On 07/09/15 18:52, Alan Bateman wrote:
On 07/09/2015 14:08, Vyom Tewari wrote:
Hi All,
Please find the latest diff, which contains the latest fix.
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.02/
I thin
On 07/09/2015 14:08, Vyom Tewari wrote:
Hi All,
Please find the latest diff, which contains the latest fix.
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.02/
I think this looks okay now.
-Alan
a couple of other considerations in the context of this issue perhaps?
in this s is being duped onto fd, and part of the dup2 operation is the
closing of fd, but
what's is the expected state of file descriptor fd in the event of a
dup2 failure?
s is closed in any case, but what about fd, sho
Thank you Chris for the review!
Sincerely yours,
Ivan
On 07.09.2015 17:39, Chris Hegarty wrote:
This looks like a nice cleanup, and fix. Thanks Ivan.
-Chris.
On 05/09/15 15:25, Ivan Gerasimov wrote:
Hi everyone!
The fix didn't bring enough attention back in February for some reason.
So, I'd
This looks like a nice cleanup, and fix. Thanks Ivan.
-Chris.
On 05/09/15 15:25, Ivan Gerasimov wrote:
Hi everyone!
The fix didn't bring enough attention back in February for some reason.
So, I'd like to re-request a review.
I've added a regression test, which reliably reproduces a deadlock o
Hi,
i want to have a closer look to JDK-8022748[1].
I make experimented a little and for me it seemed that the relativize
method is making the trouble.
Has someone had a look at it, already? Or is it a academic (relativize
on "." ) case that is described
in the bug-report? Elsewise I would invest
Hi,
On Mon, Sep 7, 2015 at 5:54 AM, Bradford Wetmore
wrote:
> IMHO, the following works well. I've added a new method that contains the
> ordered list of ciphersuites still to be tried which is a hint for ALPNinboked
> selection, but we delay the actual ciphersuite selection until after the
> AL
Thanks!
It looks good to me now.
Sincerely yours,
Ivan
On 07.09.2015 16:08, Vyom Tewari wrote:
Hi All,
Please find the latest diff, which contains the latest fix.
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.02/
Thanks,
Vyom
On 9/7/2015 3:48 PM, Alan Bateman wrote:
On 07/09/201
Hi All,
Please find the latest diff, which contains the latest fix.
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.02/
Thanks,
Vyom
On 9/7/2015 3:48 PM, Alan Bateman wrote:
On 07/09/2015 10:26, Vyom Tewari wrote:
Hi everyone,
Can you please review my changes for below bug.
Bug:
On 07/09/2015 10:26, Vyom Tewari wrote:
Hi everyone,
Can you please review my changes for below bug.
Bug:
JDK-8080402 : File Leak in
jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java
Webrev:
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.01/
This change ensure that if c
Hi!
The close() function isn't really restartable.
So, I think, it's more correct to replace
RESTARTABLE(close(s), res);
with
res = close(s);
Sincerely yours,
Ivan
On 07.09.2015 12:26, Vyom Tewari wrote:
Hi everyone,
Can you please review my changes for below bug.
Bug:
JDK-80804
Hi Vyom,
On 07/09/15 10:26, Vyom Tewari wrote:
Hi everyone,
Can you please review my changes for below bug.
Bug:
JDK-8080402 : File Leak in
jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java
Webrev:
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.01/
This change ensure th
Hi everyone,
Can you please review my changes for below bug.
Bug:
JDK-8080402 : File Leak in
jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java
Webrev:
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.01/
This change ensure that if close() fails we throw correct io exceptio
17 matches
Mail list logo