Looks good Paul, just a few minor comments. ( looked at all, but *security* and
*sql* )
NetworkInterface
s/Enumertion/Stream
L127 * will be returned in the Enumeration. However, if the caller has the
s/an/a
L131 * @return an Stream object with all or a subset of the InetAddresses
On Jun 3, 2015, at 9:27 PM, Alan Bateman wrote:
> On 03/06/2015 17:47, Paul Sandoz wrote:
>> :
>> Ok, i removed it but added an assert for the array being non-null and
>> containing at least one element. I also refined the documentation of the
>> stream returning method in light of this:
>>
>
On 03/06/2015 17:47, Paul Sandoz wrote:
:
Ok, i removed it but added an assert for the array being non-null and
containing at least one element. I also refined the documentation of the stream
returning method in light of this:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8081678-enumeratio
On Jun 3, 2015, at 12:46 PM, Alan Bateman wrote:
>
> On 02/06/2015 14:37, Paul Sandoz wrote:
>
>> :
>>
>> There is one small area of uncertainty with NetworkInterface. Can the
>> following method ever return null?
>>
>> 342 public static Enumeration getNetworkInterfaces()
>> 343
Thanks Michael,
A test would be pretty tricky given the configuration specific nature of
the problem. (Mac, VPN etc.)
-Rob
On 03/06/15 16:22, Michael McMahon wrote:
Seems reasonable Rob. I guess a test isn't feasible?
Michael.
On 03/06/15 14:25, Rob McKenna wrote:
Hi folks,
71805
Seems reasonable Rob. I guess a test isn't feasible?
Michael.
On 03/06/15 14:25, Rob McKenna wrote:
Hi folks,
7180557 used getifaddrs as a way of determining the local hosts ip
address on Mac OSX in order to fix a problem with OSX's naming system.
When fixing this we decided to place that ca
Hi folks,
7180557 used getifaddrs as a way of determining the local hosts ip
address on Mac OSX in order to fix a problem with OSX's naming system.
When fixing this we decided to place that call before the call to
getaddrinfo thus taking the naming system out of the equation.
Unfortunately w
On 02/06/2015 14:37, Paul Sandoz wrote:
:
There is one small area of uncertainty with NetworkInterface. Can the following
method ever return null?
342 public static Enumeration getNetworkInterfaces()
343 throws SocketException {
344 NetworkInterface[] netifs = getAl
