Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Alan Bateman
On 21/04/2015 16:04, Michael McMahon wrote: : http://cr.openjdk.java.net/~michaelm/8078276/webrev.1/ Before you push this, shouldn't the test have copyright Red Hat? There's an example in the same directory. -Alan

Potential infinite waiting at JMXConnection#createConnection

2015-04-21 Thread KUBOTA Yuji
Hi all, I found an infinite waiting at TCPChannel#createConnection. This method flushes the DataOutputStream without the socket timeout settings when choose stream protocol [1]. If connection lost (the destination server do no return response) during the flush, this method has possibilities to ta

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Alan Bateman
On 21/04/2015 16:04, Michael McMahon wrote: On 21/04/15 14:56, Alan Bateman wrote: : Can the test be moved to jdk/test/com/sun/jndi/dns as that seems to be where the other tests are? Also I assume this will need a copyright header before it is pushed. -Alan I had pushed it already. So, I

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Michael McMahon
On 21/04/15 14:56, Alan Bateman wrote: On 20/04/2015 18:32, Severin Gehwolf wrote: : OK fixed: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/ FWIW, I don't think the test needs IP addresses of DNS servers to be functional, though. All it really does is passing it to InetAd

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Alan Bateman
On 20/04/2015 18:32, Severin Gehwolf wrote: : OK fixed: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/ FWIW, I don't think the test needs IP addresses of DNS servers to be functional, though. All it really does is passing it to InetAddress.getByName(). Prior this patch DnsC

Re: RFR [9] 8075139: Restore java.protocol.handler.pkgs to work as a fallback for migration

2015-04-21 Thread Paul Sandoz
On Apr 21, 2015, at 12:32 PM, Alan Bateman wrote: > > > On 21/04/2015 11:20, Chris Hegarty wrote: >> On 15 Apr 2015, at 16:43, Paul Sandoz wrote: >> >>> On Apr 15, 2015, at 4:35 PM, Chris Hegarty wrote: > I marginally prefer using flatMap rather than map/filter e.g. change > getHan

Re: RFR [9] 8075139: Restore java.protocol.handler.pkgs to work as a fallback for migration

2015-04-21 Thread Alan Bateman
On 21/04/2015 11:20, Chris Hegarty wrote: On 15 Apr 2015, at 16:43, Paul Sandoz wrote: On Apr 15, 2015, at 4:35 PM, Chris Hegarty wrote: I marginally prefer using flatMap rather than map/filter e.g. change getHandler to return Stream< URLStreamHandler> and change the last line to be "retu

Re: RFR [9] 8075139: Restore java.protocol.handler.pkgs to work as a fallback for migration

2015-04-21 Thread Chris Hegarty
On 15 Apr 2015, at 16:43, Paul Sandoz wrote: > On Apr 15, 2015, at 4:35 PM, Chris Hegarty wrote: >>> >>> I marginally prefer using flatMap rather than map/filter e.g. change >>> getHandler to return Stream< URLStreamHandler> and change the last line to >>> be "return Stream.ofNullable(handle)

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Michael McMahon
On 20/04/15 18:32, Severin Gehwolf wrote: On Mon, 2015-04-20 at 12:24 -0400, Andrew Hughes wrote: - Original Message - Adding in net-dev. On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote: Hi, Could I please get a review and a sponsor for the following patch? The issue is tha