Re: [9] RFR: 8073430: Deprecate security APIs that have been superseded

2015-03-05 Thread Wang Weijun
What is the policy for deprecating a non-public-API method? > On Mar 6, 2015, at 13:30, Wang Weijun wrote: > > Instead of adding @SupressWarnings to a method, can we add @Deprecated to it?

Re: [9] RFR: 8073430: Deprecate security APIs that have been superseded

2015-03-05 Thread Wang Weijun
Instead of adding @SupressWarnings to a method, can we add @Deprecated to it? If I understand correctly, there should be no warning if a deprecated method calls another deprecated method. And by deprecating the caller we will get warnings if they are called by more methods and we can evaluate if

Re: [9] RFR: 8073430: Deprecate security APIs that have been superseded

2015-03-05 Thread Jason Uh
Hi Max, A couple of these, we probably won't be able to remove in JDK 9. I'm deprecating getPeerCertificateChain() in the javax.net.ssl.SSLSession interface in this change, so the implementation in sun.security.ssl.SSLSessionImpl will have to be suppressed. Also, X509V1CertImpl will probably

Re: [9] RFR: 8073430: Deprecate security APIs that have been superseded

2015-03-05 Thread Sean Mullan
Looks good, Jason, just a couple of comments: - Add an @Deprecated annotation to the package-info.java files since the entire package is deprecated. Put {@code} around the package/class names. - add a noreg label to the bug --Sean On 03/04/2015 02:02 PM, Jason Uh wrote: webrev: http://cr.op

RE: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

2015-03-05 Thread Michael Mcmahon
Hi, I'm afraid you have the wrong Michael McMahon. -Original Message- From: Konstantin Shefov Sent: Monday, December 15, 2014 6:16 AM To: Ivan Gerasimov; net-dev@openjdk.java.net; core-libs-...@openjdk.java.net; Alan Bateman; Chris Hegarty; MICHAEL.MCMAHON Subject: Re: [9] Review reques

[9] RFR: 8073430: Deprecate security APIs that have been superseded

2015-03-05 Thread Jason Uh
webrev: http://cr.openjdk.java.net/~juh/8073430/00/ jbs: https://bugs.openjdk.java.net/browse/JDK-8073430 Please review this change, which deprecates the classes in java.security.acl and javax.security.cert. These packages have been superseded by replacements for a long time. For java.securit

Re: RFR: JDK-8065078 - NetworkInterface.getNetworkInterfaces() triggers intermittent test failures

2015-03-05 Thread Mark Sheppard
thanks for the review Chris regards Mark On 05/03/2015 14:09, Chris Hegarty wrote: On 4 Mar 2015, at 21:53, Mark Sheppard wrote: Hi please oblige and review the following small change http://cr.openjdk.java.net/~msheppar/8065078/webrev/ I agree with the increased buffer size, and the stra

Re: RFR: JDK-8065078 - NetworkInterface.getNetworkInterfaces() triggers intermittent test failures

2015-03-05 Thread Chris Hegarty
On 4 Mar 2015, at 21:53, Mark Sheppard wrote: > Hi > please oblige and review the following small change > http://cr.openjdk.java.net/~msheppar/8065078/webrev/ I agree with the increased buffer size, and the strategy you have employed. I think you just need to remove a few comments, otherwis