Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2014-12-18 Thread Chris Hegarty
On 18 Dec 2014, at 13:20, Alan Bateman wrote: > On 18/12/2014 11:52, Chris Hegarty wrote: >> Thanks for looking at this Alan. >> >> Surprisingly this issue has existed for a long time. I tested with the FCS >> version of JRE 5, 6, 7, 8, and 9-ea, on Windows Server 2008 R2, and 2012, >> and the

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2014-12-18 Thread Dmitry Samersoff
Chris, > OK, but there can be no expectation that something like this can work > with java.net.Socket, or SocketChannel. I am only proposing to change > these two specific implementations. OK. Thank you for clarification. The fix looks good for me. -Dmitry On 2014-12-18 15:52, Chris Hegarty w

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2014-12-18 Thread Alan Bateman
On 18/12/2014 11:52, Chris Hegarty wrote: Thanks for looking at this Alan. Surprisingly this issue has existed for a long time. I tested with the FCS version of JRE 5, 6, 7, 8, and 9-ea, on Windows Server 2008 R2, and 2012, and the newly accepted socket inherit behaviour can be seen. NIO serv

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2014-12-18 Thread Chris Hegarty
On 18 Dec 2014, at 12:22, Dmitry Samersoff wrote: > Chris, > > In a windows world it's rather common to rely on socket inheritance > e.g. set socket to stdin(stdout) of child process and do CreateProcess. OK, but there can be no expectation that something like this can work with java.net.Socke

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2014-12-18 Thread Dmitry Samersoff
Chris, In a windows world it's rather common to rely on socket inheritance e.g. set socket to stdin(stdout) of child process and do CreateProcess. So please make sure your changes don't have side effects, also it might be better to control handler inheritance in one place only (at CreateProcess c

Re: RFR 8065420: Update test java/net/ResponseCache/ResponseCacheTest.java to eliminate internal API dependency

2014-12-18 Thread Chris Hegarty
This looks ok to me Amanda. -Chris. On 17 Dec 2014, at 23:23, Amanda Jiang wrote: > Hi, > > May I request your review for following changeset? > There is one networking tests that has dependency on internal API > sun.net.www.ParseUtil. > This fix is to remove the internal API dependency from

Re: RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

2014-12-18 Thread Chris Hegarty
Thanks for looking at this Alan. Surprisingly this issue has existed for a long time. I tested with the FCS version of JRE 5, 6, 7, 8, and 9-ea, on Windows Server 2008 R2, and 2012, and the newly accepted socket inherit behaviour can be seen. NIO server socket channels also suffers from the sa

Re: JEP 110: HTTP 2 Client

2014-12-18 Thread Michael McMahon
Hi Wenbo, We are just doing some prototyping at the moment, and hope to have an API proposal for discussion early in the new year. Thanks, Michael On 18/12/14 02:42, Wenbo Zhu wrote: I am new to the JEP process. Has there been any update on this work? Is there an API proposal to look at? Tha