Re: RFR 8056065: sun/net/www/protocol/http/RedirectOnPost.java failing.

2014-08-26 Thread Chris Hegarty
On 26 Aug 2014, at 15:06, Alan Bateman wrote: > On 26/08/2014 15:01, Michael McMahon wrote: >> Could I get the following small change reviewed please? >> >> One file was missed from my earlier change to SimpleSSLContext >> >> http://cr.openjdk.java.net/~michaelm/8056065/webrev.1/ > This looks o

Re: RFR 8056065: sun/net/www/protocol/http/RedirectOnPost.java failing.

2014-08-26 Thread Michael McMahon
On 26/08/14 15:06, Alan Bateman wrote: On 26/08/2014 15:01, Michael McMahon wrote: Could I get the following small change reviewed please? One file was missed from my earlier change to SimpleSSLContext http://cr.openjdk.java.net/~michaelm/8056065/webrev.1/ This looks okay to me, I assume that

Re: RFR 8056065: sun/net/www/protocol/http/RedirectOnPost.java failing.

2014-08-26 Thread Alan Bateman
On 26/08/2014 15:01, Michael McMahon wrote: Could I get the following small change reviewed please? One file was missed from my earlier change to SimpleSSLContext http://cr.openjdk.java.net/~michaelm/8056065/webrev.1/ This looks okay to me, I assume that all the :jdk_net tests are passing now.

RFR 8056065: sun/net/www/protocol/http/RedirectOnPost.java failing.

2014-08-26 Thread Michael McMahon
Could I get the following small change reviewed please? One file was missed from my earlier change to SimpleSSLContext http://cr.openjdk.java.net/~michaelm/8056065/webrev.1/ Thanks, Michael.

Re: RFR 8055901: Update policytool for jdk.net.NetworkPermission

2014-08-26 Thread Michael McMahon
On 26/08/14 09:05, Wang Weijun wrote: On Aug 26, 2014, at 15:57, Michael McMahon wrote: Thanks for doing this Max. The syntax looks fine. Just one question. Do you think it is better to specify each socket option literally in the tool as you have done (ie. the only supported NetworkPermission

Re: RFR 8055901: Update policytool for jdk.net.NetworkPermission

2014-08-26 Thread Wang Weijun
On Aug 26, 2014, at 15:57, Michael McMahon wrote: > Thanks for doing this Max. The syntax looks fine. > Just one question. Do you think it is better to specify each socket option > literally in the tool > as you have done (ie. the only supported NetworkPermission > is SO_FLOW_SLA with this chan

Re: RFR 8055901: Update policytool for jdk.net.NetworkPermission

2014-08-26 Thread Michael McMahon
Thanks for doing this Max. The syntax looks fine. Just one question. Do you think it is better to specify each socket option literally in the tool as you have done (ie. the only supported NetworkPermission is SO_FLOW_SLA with this change) or allow users to type in the option name as free-form t