Re: RFR 8049220: URL.factory data race

2014-07-07 Thread Paul Sandoz
On Jul 7, 2014, at 1:07 PM, Peter Levart wrote: > Hi Pavel, Alan and Paul, > > Thanks for reviewing. I accepted the suggestions from Pavel and Paul and > created webrev.02: > > http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/ > > Is this good to go into jdk9-dev? > Looks

Re: RFR 8049220: URL.factory data race

2014-07-07 Thread Alan Bateman
On 07/07/2014 12:07, Peter Levart wrote: Hi Pavel, Alan and Paul, Thanks for reviewing. I accepted the suggestions from Pavel and Paul and created webrev.02: http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/ Is this good to go into jdk9-dev? The comments looks okay to me (a

Re: RFR JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime (+more)

2014-07-07 Thread Michael McMahon
Peter, Thanks for the explanation. No. I think your change is good. I've run tests here locally and I'm happy with it overall. Michael On 07/07/14 14:10, Peter Levart wrote: On 07/07/2014 12:59 PM, Michael McMahon wrote: Hi Peter, Is it necessary to remove the cache entry in the local host

Re: RFR JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime (+more)

2014-07-07 Thread Peter Levart
On 07/07/2014 12:59 PM, Michael McMahon wrote: Hi Peter, Is it necessary to remove the cache entry in the local host case (L1226) ? It seems redundant to cache it here, and also explicitly in the CachedLocalHost object Michael Hi Michael, Thanks for looking into this. getLocalHost() seem

Re: RFR 8049220: URL.factory data race

2014-07-07 Thread Peter Levart
Hi Pavel, Alan and Paul, Thanks for reviewing. I accepted the suggestions from Pavel and Paul and created webrev.02: http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/ Is this good to go into jdk9-dev? Regards, Peter On 07/04/2014 04:54 PM, Paul Sandoz wrote: On Jul 3, 20

Re: RFR JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime (+more)

2014-07-07 Thread Michael McMahon
Hi Peter, Is it necessary to remove the cache entry in the local host case (L1226) ? It seems redundant to cache it here, and also explicitly in the CachedLocalHost object Michael On 02/07/14 12:56, Peter Levart wrote: Hi, I updated the webrev with first two suggestions from Bernd (expireTi