Re: Code Review request: 8047186: jdk.net.Sockets throws InvocationTargetException instead of original runtime exceptions

2014-06-18 Thread Artem Smotrakov
Hi Michael, Yes, I think it is better to throw the original runtime exception. Artem On 06/18/2014 06:28 PM, Michael McMahon wrote: On 18/06/14 13:53, Artem Smotrakov wrote: Hello, Please review this fix for 8u: https://bugs.openjdk.java.net/browse/JDK-8047186 http://cr.openjdk.java.net/~as

Re: Code Review request: 8047186: jdk.net.Sockets throws InvocationTargetException instead of original runtime exceptions

2014-06-18 Thread Michael McMahon
On 18/06/14 13:53, Artem Smotrakov wrote: Hello, Please review this fix for 8u: https://bugs.openjdk.java.net/browse/JDK-8047186 http://cr.openjdk.java.net/~asmotrak/so_flow_sla/sockets_exceptions/webrev.01/ getOption() and setOption() methods of jdk.net.Sockets class throw InvocationTarge

RFR: 8047187: Test jdk/net/Sockets/Test.java fails to compile after fix JDK-8046588

2014-06-18 Thread Michael McMahon
This is a simple test case fix for 8u-dev only. Unfortunately, the test case for 9 was backported in its entirety and makes calls to APIs not available in 8. http://cr.openjdk.java.net/~michaelm/8047187/webrev.1/ Thanks, Michael.

Code Review request: 8047186: jdk.net.Sockets throws InvocationTargetException instead of original runtime exceptions

2014-06-18 Thread Artem Smotrakov
Hello, Please review this fix for 8u: https://bugs.openjdk.java.net/browse/JDK-8047186 http://cr.openjdk.java.net/~asmotrak/so_flow_sla/sockets_exceptions/webrev.01/ getOption() and setOption() methods of jdk.net.Sockets class throw InvocationTargetException instead of actual runtime exception