RFR [9] 8040747 : Improve performance of IP address parsing

2014-04-18 Thread Claes Redestad
Hi, could I get a review of the following patch to improve IP address parsing performance? http://cr.openjdk.java.net/~mduigou/JDK-8040747/0/webrev/ https://bugs.openjdk.java.net/browse/JDK-8040747 A set of simple JMH benchmark

Re: RFR [9] 8040837: Avoid provoking NFEs when initializing InetAddrCachePolicy

2014-04-18 Thread Bernd Eckenfels
Am Fri, 18 Apr 2014 17:27:47 +0100 schrieb Michael McMahon : > I think it would be an improvement to combine these doPrivileged() > blocks as suggested, though your patch needs work Bernd. For instance, > the multi-catch doesn't work. Also the PrivilegedAction<> type is > wrong. Yes I noticed tho

Re: RFR [9] 8040837: Avoid provoking NFEs when initializing InetAddrCachePolicy

2014-04-18 Thread Mike Duigou
Claes tidied things up to produce a workable patch: > Here is the updated webrev: > > http://cr.openjdk.java.net/~mduigou/JDK-8040837/0/webrev/ > > I will push it to jdk9/dev/jdk on Friday before COB for Claes unless I hear > objections. > > Cheers, > > Mike On Apr 18 2014, at 09:27 , Michae

Re: RFR [9] 8040837: Avoid provoking NFEs when initializing InetAddrCachePolicy

2014-04-18 Thread Michael McMahon
I think it would be an improvement to combine these doPrivileged() blocks as suggested, though your patch needs work Bernd. For instance, the multi-catch doesn't work. Also the PrivilegedAction<> type is wrong. If someone wants to update it, then we can use that. Otherwise, we'll go with the orig