Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Chris Hegarty
On 09/04/2014 22:18, Alan Bateman wrote: On 09/04/2014 18:21, Chris Hegarty wrote: Michael, Alan There is/was an additional reference to the implementation specific package name in ContentHandler. It is now removed. I think this is the last one! Latest specdiff: http://cr.openjdk.java.net/~ch

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Alan Bateman
On 09/04/2014 18:21, Chris Hegarty wrote: Michael, Alan There is/was an additional reference to the implementation specific package name in ContentHandler. It is now removed. I think this is the last one! Latest specdiff: http://cr.openjdk.java.net/~chegar/8039470/02/java/net/package-summar

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Michael McMahon
Looks fine to me Chris. - Michael On 09/04/14 18:21, Chris Hegarty wrote: Michael, Alan There is/was an additional reference to the implementation specific package name in ContentHandler. It is now removed. I think this is the last one! Latest specdiff: http://cr.openjdk.java.net/~chegar/

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Chris Hegarty
Michael, Alan There is/was an additional reference to the implementation specific package name in ContentHandler. It is now removed. I think this is the last one! Latest specdiff: http://cr.openjdk.java.net/~chegar/8039470/02/java/net/package-summary.html On 09/04/14 14:33, Alan Bateman wro

Re: RFR: 8036979: Support java.net.SocketOption<> in java.net socket types

2014-04-09 Thread Michael McMahon
Thanks Alan. All comments accepted, except as clarified below. Michael On 09/04/14 15:07, Alan Bateman wrote: On 08/04/2014 18:49, Michael McMahon wrote: Could I get the following reviewed please? In addition to providing generic support for java.net.SocketOption, it also includes 8032808, wh

Re: RFR: 8036979: Support java.net.SocketOption<> in java.net socket types

2014-04-09 Thread Michael McMahon
Thanks Chris. Michael. On 09/04/14 13:34, Chris Hegarty wrote: This is a nice addition, and looks very good to me. Just a few small comments: 1) SocketImpl getOption/setOption need javadoc to describe how they can throw IOException. Maybe even the same, of similar javdoc to the socket t

Re: RFR: 8036979: Support java.net.SocketOption<> in java.net socket types

2014-04-09 Thread Alan Bateman
On 08/04/2014 18:49, Michael McMahon wrote: Could I get the following reviewed please? In addition to providing generic support for java.net.SocketOption, it also includes 8032808, which implements a platform specific socket option SO_FLOW_SLA (in jdk.net) There are changes to two repos: http:

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Alan Bateman
On 09/04/2014 14:13, Chris Hegarty wrote: Flip-flop! Thinking again about this, you're right. http://cr.openjdk.java.net/~chegar/8039470/URLConnection-report.html http://cr.openjdk.java.net/~chegar/8039470/URLConnection-report_01.html I could go further with this change, but I just want to rem

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Chris Hegarty
Flip-flop! Thinking again about this, you're right. http://cr.openjdk.java.net/~chegar/8039470/URLConnection-report.html http://cr.openjdk.java.net/~chegar/8039470/URLConnection-report_01.html I could go further with this change, but I just want to remove the reference to the sun.* package, th

Re: RFR: 8036979: Support java.net.SocketOption<> in java.net socket types

2014-04-09 Thread Chris Hegarty
This is a nice addition, and looks very good to me. Just a few small comments: 1) SocketImpl getOption/setOption need javadoc to describe how they can throw IOException. Maybe even the same, of similar javdoc to the socket type equivalent methods? 2) New protected methods in SocketImpl ne

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Michael McMahon
Chris, Okay, I think it's fine then. The term "default package" is used, but I accept it's not referred to as such, in the JLS. Thanks, Michael On 09/04/14 12:42, Chris Hegarty wrote: Thanks for looking at this Michael, On 09/04/14 11:51, Michael McMahon wrote: Is there potential for confu

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Chris Hegarty
Thanks for looking at this Michael, On 09/04/14 11:51, Michael McMahon wrote: Is there potential for confusion there? really just I just took the wording from the URL spec. I guess it was agreed upon at some point. means an "implementation defined" package rather than the Java language's

Re: RFR [9] 8039470:URLConnection.getContent incorrectly specifies the default location of content handler classes

2014-04-09 Thread Michael McMahon
Is there potential for confusion there? really just means an "implementation defined" package rather than the Java language's "default package"? Michael On 08/04/14 20:03, Chris Hegarty wrote: java.net.URLConnection.getContent() incorrectly specifies the default location of content handler