Re: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Mandy Chung
On 4/7/14 11:54 AM, Chris Hegarty wrote: Updated webrev: http://cr.openjdk.java.net/~chegar/8039362/01/webrev/ Thanks for doing this. Some minor comments: line 225: since content-types.properties is moved to the same package as MimeType class, you can simply use the relative path "conte

Re: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Chris Hegarty
[ Including Alex; there is a question/confirmation related to a change he pushed, that needs his input ] Hi Erik, thanks for your feedback, comments inline… Updated webrev: http://cr.openjdk.java.net/~chegar/8039362/01/webrev/ On 7 Apr 2014, at 16:00, Erik Joelsson wrote: > Hello Chris, >

Re: Fwd: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Erik Joelsson
Hello Chris, The changes seem to do what you intend, but I have a couple of questions. If this is a standard properties file, wouldn't it make sense to either "clean" or "compile" it like other properties files? I note that there is a macosx version of this file but from what I can see of bo

Fwd: RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Chris Hegarty
Adding build-dev ( for the makefile changes ). -Chris. Original Message Subject: RFR [9] 8039362: Read content-types.properties as a resource Date: Mon, 07 Apr 2014 15:27:43 +0100 From: Chris Hegarty To: OpenJDK Network Dev list Following JDK-8004963: "URLConnection, downgra

RFR [9] 8039362: Read content-types.properties as a resource

2014-04-07 Thread Chris Hegarty
Following JDK-8004963: "URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties", this bug [1] moves content-types.properties out of the image lib directory and into resources.jar ( to be loaded as a resources file ). This approach is acceptable, since the file