Re: RFR: [8036088] - Thread-unsafe strtok() is used to parse

2014-03-03 Thread Ivan Gerasimov
Yes, you're right. strtok() is thread-safe in Windows unlike its Unix counterpart. Thus using strtok_s() only adds some boundary checking in this case. Sincerely yours, Ivan On 04.03.2014 0:26, Salter, Thomas A wrote: strtok is thread-safe in MS C/C++. It uses thread-local store to hold its s

Re: RFR: [8036088] - Thread-unsafe strtok() is used to parse

2014-03-03 Thread Salter, Thomas A
strtok is thread-safe in MS C/C++. It uses thread-local store to hold its state. strtok_s can be called recursively to parse different strings, though it's named like the MS extensions that check for buffer overruns. http://msdn.microsoft.com/en-us/library/2c8d19sb(v=vs.100).aspx --

Re: RFR: [8036088] - Thread-unsafe strtok() is used to parse the list of overrides

2014-03-03 Thread Ivan Gerasimov
Hi Christos! On 03.03.2014 20:52, chris...@zoulas.com wrote: On Mar 3, 8:32pm, ivan.gerasi...@oracle.com (Ivan Gerasimov) wrote: -- Subject: RFR: [8036088] - Thread-unsafe strtok() is used to parse the list | Hello! | | The strtok() function is used in | ./windows/native/sun/net/spi/DefaultPro

Re: RFR: [8036088] - Thread-unsafe strtok() is used to parse the list of overrides

2014-03-03 Thread Christos Zoulas
On Mar 3, 8:32pm, ivan.gerasi...@oracle.com (Ivan Gerasimov) wrote: -- Subject: RFR: [8036088] - Thread-unsafe strtok() is used to parse the list | Hello! | | The strtok() function is used in | ./windows/native/sun/net/spi/DefaultProxySelector.c. | This function is not thread safe, so it may po

Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-03-03 Thread Alan Bateman
On 03/03/2014 16:45, Chris Hegarty wrote: Alan, I pushed this changes before receiving your comments. If you agree, I'll push the following changes under a new bug number. http://cr.openjdk.java.net/~chegar/8035897/webrev.comments/webrev/ The error handling seems a little overly complicated

Re: RFR [9] 8035897 : FD_SETSIZE should be set on macosx

2014-03-03 Thread Chris Hegarty
Alan, I pushed this changes before receiving your comments. If you agree, I'll push the following changes under a new bug number. http://cr.openjdk.java.net/~chegar/8035897/webrev.comments/webrev/ The error handling seems a little overly complicated in PlainDatagramSocketImpl, but I don't pr

RFR: [8036088] - Thread-unsafe strtok() is used to parse the list of overrides

2014-03-03 Thread Ivan Gerasimov
Hello! The strtok() function is used in ./windows/native/sun/net/spi/DefaultProxySelector.c. This function is not thread safe, so it may potentially cause a problem. The failure in this particular place would be very unlikely, because this code should be executed only once during initializati