RFR[9](M): 8035949 : Remove unused macro USE_SELECT and clean up Unix version of net_util_md.{c,h}

2014-02-27 Thread Volker Simonis
Hi, could you please review the following clean-up change (for a better formatted description please see the webrev): http://cr.openjdk.java.net/~simonis/webrevs/8035949/ https://bugs.openjdk.java.net/browse/JDK-8035949 This change removes some unused code and macros from src/solaris/native/java

Re: RFR for bug JDK-8035633 TEST_BUG: java/net/NetworkInterface/Equals.java and some tests failed on windows intermittently

2014-02-27 Thread Eric Wang
Hi Ivan & Chris, Thank you for the comments. I have corrected the typo in the comment and reverted the year of copyright. Please help to review it again. http://cr.openjdk.java.net/~ewang/JDK-8035633/webrev.01/ Chris, Could you plea

Re: RFR for bug JDK-8035633 TEST_BUG: java/net/NetworkInterface/Equals.java and some tests failed on windows intermittently

2014-02-27 Thread Ivan Gerasimov
Hello Eric Would you please also correct the comment on the line above your change: s/seudo/pseudo/ The typo is in all three files. Sincerely yours, Ivan On 27.02.2014 12:18, Eric Wang wrote: On 2014/2/25 16:59, Alan Bateman wrote: On 25/02/2014 08:49, Eric Wang wrote: Hi Everyone, I'm wo

Re: RFR for bug JDK-8035633 TEST_BUG: java/net/NetworkInterface/Equals.java and some tests failed on windows intermittently

2014-02-27 Thread Chris Hegarty
On 27 Feb 2014, at 08:18, Eric Wang wrote: >> ….. > > Thanks Alan to suggest the correct alias! > Below is the webrev for this bug, Can you or anyone else help to review the > fix? > http://cr.openjdk.java.net/~ewang/JDK-8035633/webrev.00/ >

Re: RFR for bug JDK-8035633 TEST_BUG: java/net/NetworkInterface/Equals.java and some tests failed on windows intermittently

2014-02-27 Thread Eric Wang
On 2014/2/25 16:59, Alan Bateman wrote: On 25/02/2014 08:49, Eric Wang wrote: Hi Everyone, I'm working on the test bug https://bugs.openjdk.java.net/browse/JDK-8035633, There are 4 tests (one is in a closed test) failed due to NullPointerException. All tests failed at similar places "if (isWi