Thanks for jumping on this Michael, one of my recent changes caused the
problem.
Your fix looks good to me. Trivially, the test has a 2006 copyright header.
-Chris.
On 24/02/14 17:55, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michael
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8035653/webrev.1/
We overlooked one place where JNI native field initialization
is required in Windows Vista+
Thanks
Michael.
Hi Mark,
I think join should be sufficient here.
I understand your argument to move selector close into stop, but that
just seems to require extra co-ordination between stop and the
dispatcher loop, namely you now need to check if the selector is closed
in a few places. I think it is simpler
Latest webrev:
http://chhegar.ie.oracle.com/chhegar/repos/jdk9/dev/dev/jdk/8034174/webrev.01/webrev/
-Chris.
On 24/02/14 14:12, Michael McMahon wrote:
On 24/02/14 14:09, Chris Hegarty wrote:
On 24/02/14 10:42, Michael McMahon wrote:
On 23/02/14 08:55, Chris Hegarty wrote:
On 22 Feb 2014, a
Chris,
You probably need to modify
jdk/make/mapfiles/libnet/mapfile-vers
-Dmitry
On 2014-02-24 18:19, Chris Hegarty wrote:
> On 24/02/14 14:12, Michael McMahon wrote:
>> On 24/02/14 14:09, Chris Hegarty wrote:
>>> On 24/02/14 10:42, Michael McMahon wrote:
On 23/02/14 08:55, Chris Hegarty w
On 24/02/14 14:12, Michael McMahon wrote:
On 24/02/14 14:09, Chris Hegarty wrote:
On 24/02/14 10:42, Michael McMahon wrote:
On 23/02/14 08:55, Chris Hegarty wrote:
On 22 Feb 2014, at 17:23, Dmitry Samersoff
wrote:
Chris,
Didn't look to windows part. Unix part looks good for me. See also
be
On 24/02/14 14:09, Chris Hegarty wrote:
On 24/02/14 10:42, Michael McMahon wrote:
On 23/02/14 08:55, Chris Hegarty wrote:
On 22 Feb 2014, at 17:23, Dmitry Samersoff
wrote:
Chris,
Didn't look to windows part. Unix part looks good for me. See also
below.
I'm a bit concerned because of mixing
On 24/02/14 10:42, Michael McMahon wrote:
On 23/02/14 08:55, Chris Hegarty wrote:
On 22 Feb 2014, at 17:23, Dmitry Samersoff
wrote:
Chris,
Didn't look to windows part. Unix part looks good for me. See also
below.
I'm a bit concerned because of mixing NET_* abstractions and direct call
to OS
On 23/02/14 08:55, Chris Hegarty wrote:
On 22 Feb 2014, at 17:23, Dmitry Samersoff wrote:
Chris,
Didn't look to windows part. Unix part looks good for me. See also below.
I'm a bit concerned because of mixing NET_* abstractions and direct call
to OS functions. It might be better to create NE
