Re: RFR [9]: 8034174 Remove use of JVM_* functions from java.net code

2014-02-22 Thread Dmitry Samersoff
Chris, Didn't look to windows part. Unix part looks good for me. See also below. I'm a bit concerned because of mixing NET_* abstractions and direct call to OS functions. It might be better to create NET_socket etc. We use NET_GetSockOpt/NET_SetSockOpt in one places and plain os functions in oth

Re: RFR [9]: 8034174 Remove use of JVM_* functions from java.net code

2014-02-22 Thread Alan Bateman
On 22/02/2014 14:03, Bernd Eckenfels wrote: Hm, I actually like to have that JVM_ abstraction layer. Looks like it is now replaced by NET_ in some parts, do we really want to remove it in others? (the JVM_IO_ERR beeing an obvious advantage) Support for green threads went away when we moved to

Re: RFR [9]: 8034174 Remove use of JVM_* functions from java.net code

2014-02-22 Thread Bernd Eckenfels
Hello, > Am 22.02.2014 um 10:33 schrieb Alan Bateman : > >> http://cr.openjdk.java.net/~chegar/8034174/webrev.00/webrev/ > Thank for you for doing this, it's long over due. Hm, I actually like to have that JVM_ abstraction layer. Looks like it is now replaced by NET_ in some parts, do we really

Re: RFR [9]: 8034174 Remove use of JVM_* functions from java.net code

2014-02-22 Thread Alan Bateman
On 22/02/2014 08:29, Chris Hegarty wrote: Interruptible I/O on Solaris has been highly problematic and the long standing plan has been to remove it from the JDK. In JDK6 the VM option UseVMInterruptibleIO was introduced to allow developers/customers experiment with disabling it. In JDK7 the def

RFR [9]: 8034174 Remove use of JVM_* functions from java.net code

2014-02-22 Thread Chris Hegarty
Interruptible I/O on Solaris has been highly problematic and the long standing plan has been to remove it from the JDK. In JDK6 the VM option UseVMInterruptibleIO was introduced to allow developers/customers experiment with disabling it. In JDK7 the default value of UseVMInterruptibleIO was cha